From: Kalle Valo <kvalo@codeaurora.org>
To: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Cc: Paul Stewart <pstew@chromium.org>,
Doug Anderson <dianders@chromium.org>,
linux-rockchip@lists.infradead.org,
Arend van Spriel <arend@broadcom.com>,
Pieter-Paul Giesberts <pieterpg@broadcom.com>,
brcm80211-dev-list@broadcom.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
Hante Meuleman <meuleman@broadcom.com>,
Brett Rudley <brudley@broadcom.com>,
netdev@vger.kernel.org,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>
Subject: Re: brcmfmac: sdio: Increase the default timeouts a bit
Date: Sat, 6 Feb 2016 11:59:10 +0000 (UTC) [thread overview]
Message-ID: <20160206115910.E1D026029F@smtp.codeaurora.org> (raw)
In-Reply-To: <1453718849-3508-1-git-send-email-sjoerd.simons@collabora.co.uk>
> On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems
> the card responds very quickly most of the time, unfortunately during
> initialisation it sometimes seems to take just a bit over 2 seconds to
> respond.
>
> This results intialization failing with message like:
> brcmf_c_preinit_dcmds: Retreiving cur_etheraddr failed, -52
> brcmf_bus_start: failed: -52
> brcmf_sdio_firmware_callback: dongle is not responding
>
> Increasing the timeout to allow for a bit more headroom allows the
> card to initialize reliably.
>
> A quick search online after diagnosing/fixing this showed that Google
> has a similar patch in their ChromeOS tree, so this doesn't seem
> specific to the board I'm using.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
> Acked-by: Arend van Spriel <arend@broadcom.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
next prev parent reply other threads:[~2016-02-06 11:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 10:47 [PATCH] brcmfmac: sdio: Increase the default timeouts a bit Sjoerd Simons
2016-01-25 11:06 ` Julian Calaby
[not found] ` <CAGRGNgXWE=b52Mcy8NsKBZS_4gz-TUiuFipjsuTZh1xjja=uUg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-25 15:39 ` Arend van Spriel
2016-01-25 23:41 ` Julian Calaby
2016-01-26 6:29 ` Arend van Spriel
2016-01-25 15:36 ` Arend van Spriel
2016-01-25 15:55 ` Sjoerd Simons
2016-01-25 19:23 ` Doug Anderson
2016-01-25 20:07 ` Arend van Spriel
[not found] ` <56A68064.5020702-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-01-25 20:32 ` Doug Anderson
2016-01-26 9:12 ` Sjoerd Simons
2016-02-06 11:59 ` Kalle Valo [this message]
[not found] ` <1453718849-3508-1-git-send-email-sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2016-02-06 11:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160206115910.E1D026029F@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=dianders@chromium.org \
--cc=frankyl@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pieterpg@broadcom.com \
--cc=pstew@chromium.org \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).