* [PATCH iproute2] bridge: support for static fdb entries
@ 2016-01-27 17:09 Roopa Prabhu
2016-01-27 19:30 ` Rosen, Rami
2016-02-07 19:41 ` Stephen Hemminger
0 siblings, 2 replies; 3+ messages in thread
From: Roopa Prabhu @ 2016-01-27 17:09 UTC (permalink / raw)
To: stephen; +Cc: netdev, wkok, scotte, nikolay, makita.toshiaki
From: Roopa Prabhu <roopa@cumulusnetworks.com>
There is no intuitive option to add static fdb entries today.
'temp' seems to have a side effect of adding
'static' fdb entries. But the name and intent
of 'temp' does not say anything about it being static.
example:
bridge fdb add operates as follows:
$bridge fdb add 00:01:02:03:04:05 dev eth0 master
$bridge fdb add 00:01:02:03:04:06 dev eth0 master temp
$bridge fdb add 00:01:02:03:04:07 dev eth0 master local
$bridge fdb show
00:01:02:03:04:05 dev eth0 permanent
00:01:02:03:04:06 dev eth0 static
00:01:02:03:04:07 dev eth0 permanent
00:01:02:03:04:08 dev eth0 <<== dynamic, ageable learned mac
This patch adds a new bridge fdb type 'static' which
makes sure NUD_NOARP and NUD_REACHABLE is set for static
entries. This effectively is nothing but what 'temp'
does today. But the name 'temp' is misleading.
After the patch:
$bridge fdb add 00:01:02:03:04:06 dev eth0 master static
$bridge fdb show
00:01:02:03:04:06 dev eth0 static
'temp' could ideally be a dynamic mac that can age (ie just
NUD_REACHABLE). But, 'temp' sets 'NUD_NOARP' and 'NUD_REACHABLE'.
Too late to change 'temp' now. But, we are thinking of introduing a
'dynamic' keyword after this patch that only sets NUD_REACHABLE.
Signed-off-by: Wilson Kok <wkok@cumulusnetworks.com>
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
---
Will submit another patch to document bridge fdb options
once we agree on the behaviour and this patch is accepted.
bridge/fdb.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/bridge/fdb.c b/bridge/fdb.c
index 4d10925..9bc6b94 100644
--- a/bridge/fdb.c
+++ b/bridge/fdb.c
@@ -33,7 +33,7 @@ static void usage(void)
{
fprintf(stderr, "Usage: bridge fdb { add | append | del | replace } ADDR dev DEV\n"
" [ self ] [ master ] [ use ] [ router ]\n"
- " [ local | temp ] [ dst IPADDR ] [ vlan VID ]\n"
+ " [ local | temp | static ] [ dst IPADDR ] [ vlan VID ]\n"
" [ port PORT] [ vni VNI ] [ via DEV ]\n");
fprintf(stderr, " bridge fdb [ show [ br BRDEV ] [ brport DEV ] ]\n");
exit(-1);
@@ -301,7 +301,8 @@ static int fdb_modify(int cmd, int flags, int argc, char **argv)
} else if (matches(*argv, "local") == 0||
matches(*argv, "permanent") == 0) {
req.ndm.ndm_state |= NUD_PERMANENT;
- } else if (matches(*argv, "temp") == 0) {
+ } else if (matches(*argv, "temp") == 0 ||
+ matches(*argv, "static") == 0) {
req.ndm.ndm_state |= NUD_REACHABLE;
} else if (matches(*argv, "vlan") == 0) {
if (vid >= 0)
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH iproute2] bridge: support for static fdb entries
2016-01-27 17:09 [PATCH iproute2] bridge: support for static fdb entries Roopa Prabhu
@ 2016-01-27 19:30 ` Rosen, Rami
2016-02-07 19:41 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Rosen, Rami @ 2016-01-27 19:30 UTC (permalink / raw)
To: Roopa Prabhu, stephen@networkplumber.org
Cc: netdev@vger.kernel.org, wkok@cumulusnetworks.com,
scotte@cumulusnetworks.com, nikolay@cumulusnetworks.com,
makita.toshiaki@lab.ntt.co.jp, Rosen, Rami
+1
'temp' seems indeed not to be intuitive enough as 'static' in this context.
Regards,
Rami Rosen
Intel Corporation
-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On Behalf Of Roopa Prabhu
Sent: Wednesday, January 27, 2016 7:10 PM
To: stephen@networkplumber.org
Cc: netdev@vger.kernel.org; wkok@cumulusnetworks.com; scotte@cumulusnetworks.com; nikolay@cumulusnetworks.com; makita.toshiaki@lab.ntt.co.jp
Subject: [PATCH iproute2] bridge: support for static fdb entries
From: Roopa Prabhu <roopa@cumulusnetworks.com>
There is no intuitive option to add static fdb entries today.
'temp' seems to have a side effect of adding
'static' fdb entries. But the name and intent
of 'temp' does not say anything about it being static.
example:
bridge fdb add operates as follows:
$bridge fdb add 00:01:02:03:04:05 dev eth0 master
$bridge fdb add 00:01:02:03:04:06 dev eth0 master temp
$bridge fdb add 00:01:02:03:04:07 dev eth0 master local
$bridge fdb show
00:01:02:03:04:05 dev eth0 permanent
00:01:02:03:04:06 dev eth0 static
00:01:02:03:04:07 dev eth0 permanent
00:01:02:03:04:08 dev eth0 <<== dynamic, ageable learned mac
This patch adds a new bridge fdb type 'static' which
makes sure NUD_NOARP and NUD_REACHABLE is set for static
entries. This effectively is nothing but what 'temp'
does today. But the name 'temp' is misleading.
After the patch:
$bridge fdb add 00:01:02:03:04:06 dev eth0 master static
$bridge fdb show
00:01:02:03:04:06 dev eth0 static
'temp' could ideally be a dynamic mac that can age (ie just
NUD_REACHABLE). But, 'temp' sets 'NUD_NOARP' and 'NUD_REACHABLE'.
Too late to change 'temp' now. But, we are thinking of introduing a
'dynamic' keyword after this patch that only sets NUD_REACHABLE.
Signed-off-by: Wilson Kok <wkok@cumulusnetworks.com>
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
---
Will submit another patch to document bridge fdb options
once we agree on the behaviour and this patch is accepted.
bridge/fdb.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/bridge/fdb.c b/bridge/fdb.c
index 4d10925..9bc6b94 100644
--- a/bridge/fdb.c
+++ b/bridge/fdb.c
@@ -33,7 +33,7 @@ static void usage(void)
{
fprintf(stderr, "Usage: bridge fdb { add | append | del | replace } ADDR dev DEV\n"
" [ self ] [ master ] [ use ] [ router ]\n"
- " [ local | temp ] [ dst IPADDR ] [ vlan VID ]\n"
+ " [ local | temp | static ] [ dst IPADDR ] [ vlan VID ]\n"
" [ port PORT] [ vni VNI ] [ via DEV ]\n");
fprintf(stderr, " bridge fdb [ show [ br BRDEV ] [ brport DEV ] ]\n");
exit(-1);
@@ -301,7 +301,8 @@ static int fdb_modify(int cmd, int flags, int argc, char **argv)
} else if (matches(*argv, "local") == 0||
matches(*argv, "permanent") == 0) {
req.ndm.ndm_state |= NUD_PERMANENT;
- } else if (matches(*argv, "temp") == 0) {
+ } else if (matches(*argv, "temp") == 0 ||
+ matches(*argv, "static") == 0) {
req.ndm.ndm_state |= NUD_REACHABLE;
} else if (matches(*argv, "vlan") == 0) {
if (vid >= 0)
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH iproute2] bridge: support for static fdb entries
2016-01-27 17:09 [PATCH iproute2] bridge: support for static fdb entries Roopa Prabhu
2016-01-27 19:30 ` Rosen, Rami
@ 2016-02-07 19:41 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2016-02-07 19:41 UTC (permalink / raw)
To: Roopa Prabhu; +Cc: netdev, wkok, scotte, nikolay, makita.toshiaki
On Wed, 27 Jan 2016 09:09:37 -0800
Roopa Prabhu <roopa@cumulusnetworks.com> wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> There is no intuitive option to add static fdb entries today.
> 'temp' seems to have a side effect of adding
> 'static' fdb entries. But the name and intent
> of 'temp' does not say anything about it being static.
>
> example:
> bridge fdb add operates as follows:
>
> $bridge fdb add 00:01:02:03:04:05 dev eth0 master
> $bridge fdb add 00:01:02:03:04:06 dev eth0 master temp
> $bridge fdb add 00:01:02:03:04:07 dev eth0 master local
>
> $bridge fdb show
> 00:01:02:03:04:05 dev eth0 permanent
> 00:01:02:03:04:06 dev eth0 static
> 00:01:02:03:04:07 dev eth0 permanent
> 00:01:02:03:04:08 dev eth0 <<== dynamic, ageable learned mac
>
> This patch adds a new bridge fdb type 'static' which
> makes sure NUD_NOARP and NUD_REACHABLE is set for static
> entries. This effectively is nothing but what 'temp'
> does today. But the name 'temp' is misleading.
>
> After the patch:
> $bridge fdb add 00:01:02:03:04:06 dev eth0 master static
>
> $bridge fdb show
> 00:01:02:03:04:06 dev eth0 static
>
> 'temp' could ideally be a dynamic mac that can age (ie just
> NUD_REACHABLE). But, 'temp' sets 'NUD_NOARP' and 'NUD_REACHABLE'.
> Too late to change 'temp' now. But, we are thinking of introduing a
> 'dynamic' keyword after this patch that only sets NUD_REACHABLE.
>
> Signed-off-by: Wilson Kok <wkok@cumulusnetworks.com>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> ---
> Will submit another patch to document bridge fdb options
> once we agree on the behaviour and this patch is accepted.
>
> bridge/fdb.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Appled.
Please update man page
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-07 19:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-27 17:09 [PATCH iproute2] bridge: support for static fdb entries Roopa Prabhu
2016-01-27 19:30 ` Rosen, Rami
2016-02-07 19:41 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).