* [net] bonding: trivial: style fixes
@ 2016-02-03 2:02 Zhang Shengju
2016-02-08 15:46 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Shengju @ 2016-02-03 2:02 UTC (permalink / raw)
To: j.vosburgh, netdev
remove some redudant brackets, use sizeof(*) instead of sizeof(struct x).
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
---
drivers/net/bonding/bond_main.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index fb4c52f..bcc7b19 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -928,11 +928,10 @@ void bond_select_active_slave(struct bonding *bond)
if (!rv)
return;
- if (netif_carrier_ok(bond->dev)) {
+ if (netif_carrier_ok(bond->dev))
netdev_info(bond->dev, "first active interface up!\n");
- } else {
+ else
netdev_info(bond->dev, "now running without any active interface!\n");
- }
}
}
@@ -1178,9 +1177,8 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb)
}
}
- if (bond_should_deliver_exact_match(skb, slave, bond)) {
+ if (bond_should_deliver_exact_match(skb, slave, bond))
return RX_HANDLER_EXACT;
- }
skb->dev = bond->dev;
@@ -1241,7 +1239,7 @@ static struct slave *bond_alloc_slave(struct bonding *bond)
{
struct slave *slave = NULL;
- slave = kzalloc(sizeof(struct slave), GFP_KERNEL);
+ slave = kzalloc(sizeof(*slave), GFP_KERNEL);
if (!slave)
return NULL;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net] bonding: trivial: style fixes
2016-02-03 2:02 [net] bonding: trivial: style fixes Zhang Shengju
@ 2016-02-08 15:46 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-02-08 15:46 UTC (permalink / raw)
To: zhangshengju; +Cc: j.vosburgh, netdev
From: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Date: Wed, 3 Feb 2016 02:02:32 +0000
> remove some redudant brackets, use sizeof(*) instead of sizeof(struct x).
>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-08 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-03 2:02 [net] bonding: trivial: style fixes Zhang Shengju
2016-02-08 15:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).