From: Jakub Kicinski <moorray3@wp.pl>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] fm10k: correctly report error when changing number of channels
Date: Mon, 8 Feb 2016 13:26:32 +0000 [thread overview]
Message-ID: <20160208132632.3010dee3@jkicinski-Precision-T1700> (raw)
In-Reply-To: <1454704221-14238-3-git-send-email-jacob.e.keller@intel.com>
Hi Jacob!
First of all thanks for putting your time into sorting this out,
figuring out what to do with user-set RSS table when queues are
reconfigured was a head scratcher for me as well.
On Fri, 5 Feb 2016 12:30:21 -0800, Jacob Keller wrote:
> +#define FM10K_FLAG_RETA_TABLE_CONFIGURED (u32)(BIT(6))
If we go with your proposal every driver will have to keep track of
how the RSS table was set and find max value on queue reconfig -
replicating effort and leaving space for diverging behaviour...
Would it be worth considering to place more of this code in the core?
next prev parent reply other threads:[~2016-02-08 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 20:30 [PATCH 0/2] ethtool: {SG}RXFH indirection deficiency Jacob Keller
2016-02-05 20:30 ` [PATCH 1/2] ethtool: support notifying drivers when user requests default rxfh table Jacob Keller
2016-02-05 20:30 ` [PATCH 2/2] fm10k: correctly report error when changing number of channels Jacob Keller
2016-02-08 13:26 ` Jakub Kicinski [this message]
2016-02-08 17:13 ` Keller, Jacob E
2016-02-08 19:23 ` Jakub Kiciński
2016-02-08 20:07 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208132632.3010dee3@jkicinski-Precision-T1700 \
--to=moorray3@wp.pl \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox