From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, pety@rusnet.ru
Subject: Re: [PATCH net] tcp: do not drop syn_recv on all icmp reports
Date: Tue, 09 Feb 2016 04:17:53 -0500 (EST) [thread overview]
Message-ID: <20160209.041753.1270582307290270805.davem@davemloft.net> (raw)
In-Reply-To: <1454470272.7627.223.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 02 Feb 2016 19:31:12 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Petr Novopashenniy reported that ICMP redirects on SYN_RECV sockets
> were leading to RST.
>
> This is of course incorrect.
>
> A specific list of ICMP messages should be able to drop a SYN_RECV.
>
> For instance, a REDIRECT on SYN_RECV shall be ignored, as we do
> not hold a dst per SYN_RECV pseudo request.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=111751
> Fixes: 079096f103fa ("tcp/dccp: install syn_recv requests into ehash table")
> Reported-by: Petr Novopashenniy <pety@rusnet.ru>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable, thanks Eric.
prev parent reply other threads:[~2016-02-09 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 0:56 Fw: [Bug 111751] New: Kernel send tcp reset when receive icmp redirect Stephen Hemminger
2016-02-03 2:35 ` Eric Dumazet
2016-02-03 3:31 ` [PATCH net] tcp: do not drop syn_recv on all icmp reports Eric Dumazet
2016-02-09 9:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160209.041753.1270582307290270805.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pety@rusnet.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox