netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: John Holland <jotihojr@gmail.com>,
	intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob
Date: Tue, 9 Feb 2016 12:54:30 +0100	[thread overview]
Message-ID: <20160209115430.GD18781@lunn.ch> (raw)
In-Reply-To: <1455015744.3592.46.camel@intel.com>

> > +static void igb_read_mac_addr_dts(struct e1000_hw *hw)
> > +{
> > +       const u8 *mac;
> > +       struct device_node *dn;
> > +
> > +       dn = of_find_compatible_node(NULL, NULL, "intel,i211");

Hi John

Would this also work for the i210?

If so, you normally use the compatible string for the first device
this works with. So maybe this should be changed to intel,i210?

Thanks
	Andrew

  reply	other threads:[~2016-02-09 11:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29 22:11 [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob John Holland
2016-02-09 11:02 ` Jeff Kirsher
2016-02-09 11:54   ` Andrew Lunn [this message]
2016-02-10  9:13     ` John Holland
2016-02-10 16:59       ` Andrew Lunn
2016-02-09 11:59   ` Andrew Lunn
2016-02-09 17:42     ` Shannon Nelson
2016-02-09 22:10       ` David Miller
2016-02-10  8:50       ` John Holland
2016-02-10  9:16     ` John Holland
2016-02-10  8:52   ` John Holland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160209115430.GD18781@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jotihojr@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).