From: David Miller <davem@davemloft.net>
To: asd@marian1000.go.ro
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net v4] r8169: Bad implementation of netif_carrier_*
Date: Thu, 11 Feb 2016 06:12:50 -0500 (EST) [thread overview]
Message-ID: <20160211.061250.1340671752357908695.davem@davemloft.net> (raw)
In-Reply-To: <1455187969.3447.4.camel@marian1000.go.ro>
From: Corcodel Marian <asd@marian1000.go.ro>
Date: Thu, 11 Feb 2016 12:52:49 +0200
> On Thu, 2016-02-11 at 03:39 -0500, David Miller wrote:
>> From: Corcodel Marian <asd@marian1000.go.ro>
>> Date: Thu, 11 Feb 2016 08:27:43 +0200
>>
>> > On probe stage what carrier to stop and rest two situation
>> > netif_carrier_* is slow and disturbing autonegociation process.
>> >
>> > Signed-off-by: Corcodel Marian <asd@marian1000.go.ro>
>>
>> This doesn't tell us at all why your change is valid. You aren't
>> going into the details of what you mean by "disturbing" and why it
>> being "slow" is really a problem.
>>
>> In general, your patches are of a very low quality. You give never
>> give us enough information to properly evaluate your patch.
>>
>> It is unlikely that even one of your patches will be applied by
>> me until you fix this fundamental problem with your submissions.
>
> May bee netif_carrier_* is good on slow changes of link good status of
> interrupt ,is unable to keep track changes from link good interrupt.
You're still not telling us anything.
The situation with your submissions is not improving.
Sorry.
next prev parent reply other threads:[~2016-02-11 11:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 6:27 [PATCH net v4] r8169: Bad implementation of netif_carrier_* Corcodel Marian
2016-02-11 8:39 ` David Miller
2016-02-11 10:52 ` Corcodel Marian
2016-02-11 11:12 ` David Miller [this message]
2016-02-11 11:41 ` Corcodel Marian
2016-02-12 13:40 ` Corcodel Marian
2016-02-12 16:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211.061250.1340671752357908695.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=asd@marian1000.go.ro \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).