netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: aduyck@mirantis.com
Cc: netdev@vger.kernel.org, alexander.duyck@gmail.com,
	ecree@solarflare.com, tom@herbertland.com
Subject: Re: [net-next PATCH 00/10] Add GSO support for outer checksum w/ inner checksum offloads
Date: Thu, 11 Feb 2016 09:32:06 -0500 (EST)	[thread overview]
Message-ID: <20160211.093206.798004360524314137.davem@davemloft.net> (raw)
In-Reply-To: <20160205232109.18529.99816.stgit@localhost.localdomain>

From: Alexander Duyck <aduyck@mirantis.com>
Date: Fri, 05 Feb 2016 15:27:25 -0800

> This patch series updates the existing segmentation offload code for
> tunnels to make better use of existing and updated GSO checksum
> computation.  This is done primarily through two mechanisms.  First we
> maintain a separate checksum in the GSO context block of the sk_buff.  This
> allows us to maintain two checksum values, one offloaded with values stored
> in csum_start and csum_offset, and one computed and tracked in
> SKB_GSO_CB(skb)->csum.  By maintaining these two values we are able to take
> advantage of the same sort of math used in local checksum offload so that
> we can provide both inner and outer checksums with minimal overhead.
> 
> Below is the performance for a netperf session between an ixgbe PF and VF
> on the same host but in different namespaces.  As can be seen a significant
> gain in performance can be had from allowing the use of Tx checksum offload
> on the inner headers while performing a software offload on the outer
> header computation:
> 
>  Recv   Send   Send                       Utilization  Service Demand
>  Socket Socket Message Elapsed            Send  Recv   Send  Recv
>  Size   Size   Size    Time    Throughput local remote local remote
>  bytes  bytes  bytes   secs.   10^6bits/s % S   % U    us/KB us/KB
> 
> Before:
>  87380  16384  16384   10.00   12844.38   9.30  -1.00  0.712 -1.00
> After:
>  87380  16384  16384   10.00   13216.63   6.78  -1.00  0.504 -1.000
> 
> Changes from v1:
> * Dropped use of CHECKSUM_UNNECESSARY for remote checksum offload
> * Left encap_hdr_csum as it will likely be needed in future for SCTP GSO
> * Broke the changes out over many more patches
> * Updated GRE segmentation to more closely match UDP tunnel segmentation

Series applied, thanks Alex.

      parent reply	other threads:[~2016-02-11 14:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05 23:27 [net-next PATCH 00/10] Add GSO support for outer checksum w/ inner checksum offloads Alexander Duyck
2016-02-05 23:27 ` [net-next PATCH 01/10] net: Drop unecessary enc_features variable from tunnel segmentation functions Alexander Duyck
2016-02-06 20:38   ` Tom Herbert
2016-02-05 23:27 ` [net-next PATCH 02/10] net: Move GSO csum into SKB_GSO_CB Alexander Duyck
2016-02-06 20:41   ` Tom Herbert
2016-02-05 23:27 ` [net-next PATCH 03/10] net: Update remote checksum segmentation to support use of GSO checksum Alexander Duyck
2016-02-06 20:44   ` Tom Herbert
2016-02-07 10:13     ` Alexander Duyck
2016-02-05 23:27 ` [net-next PATCH 04/10] net: Store checksum result for offloaded GSO checksums Alexander Duyck
2016-02-05 23:27 ` [net-next PATCH 05/10] net: Move skb_has_shared_frag check out of GRE code and into segmentation Alexander Duyck
2016-02-06 20:45   ` Tom Herbert
2016-02-05 23:28 ` [net-next PATCH 06/10] gre: Use GSO flags to determine csum need instead of GRE flags Alexander Duyck
2016-02-06 20:52   ` Tom Herbert
2016-02-07 10:06     ` Alexander Duyck
2016-02-05 23:28 ` [net-next PATCH 07/10] gre: Use inner_proto to obtain inner header protocol Alexander Duyck
2016-02-06 20:55   ` Tom Herbert
2016-02-07 10:11     ` Alexander Duyck
2016-02-05 23:28 ` [net-next PATCH 08/10] udp: Clean up the use of flags in UDP segmentation offload Alexander Duyck
2016-02-06 20:57   ` Tom Herbert
2016-02-05 23:28 ` [net-next PATCH 09/10] udp: Use uh->len instead of skb->len to compute checksum in segmentation Alexander Duyck
2016-02-06 20:59   ` Tom Herbert
2016-02-05 23:28 ` [net-next PATCH 10/10] net: Allow tunnels to use inner checksum offloads with outer checksums needed Alexander Duyck
2016-02-06 21:00   ` Tom Herbert
2016-02-11 14:32 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160211.093206.798004360524314137.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=aduyck@mirantis.com \
    --cc=alexander.duyck@gmail.com \
    --cc=ecree@solarflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).