From: David Miller <davem@davemloft.net>
To: amitoj1606@gmail.com
Cc: t.sailer@alumni.ethz.ch, linux-hams@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
y2038@lists.linaro.org
Subject: Re: [PATCH] net: hamradio: baycom_ser_fdx: Replace timeval with timespec64
Date: Thu, 11 Feb 2016 09:55:34 -0500 (EST) [thread overview]
Message-ID: <20160211.095534.840091300723732679.davem@davemloft.net> (raw)
In-Reply-To: <20160210043854.GA29381@amitoj-Inspiron-3542>
From: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Date: Wed, 10 Feb 2016 10:08:54 +0530
> 32 bit systems using 'struct timeval' will break in the year 2038, so
> we replace the code appropriately. However, this driver is not broken
> in 2038 since we are only using microseconds portion of the time.
>
> This patch replaces 'struct timeval' with 'struct timespec64'. We only
> need to find elapsed microseconds rather than absolute time, so it's
> better to use monotonic time, so using ktime_get_ts64() makes the code
> more efficient and more robust against concurrent settimeofday()
> calls.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Applied.
prev parent reply other threads:[~2016-02-11 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 4:38 [PATCH] net: hamradio: baycom_ser_fdx: Replace timeval with timespec64 Amitoj Kaur Chawla
2016-02-10 10:45 ` Thomas Sailer
2016-02-11 14:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211.095534.840091300723732679.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amitoj1606@gmail.com \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=t.sailer@alumni.ethz.ch \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).