From: David Miller <davem@davemloft.net>
To: zhangshengju@cmss.chinamobile.com
Cc: j.vosburgh@gmail.com, netdev@vger.kernel.org
Subject: Re: [net-next v2] bonding: use return instead of goto
Date: Thu, 11 Feb 2016 09:57:24 -0500 (EST) [thread overview]
Message-ID: <20160211.095724.1673577316117980850.davem@davemloft.net> (raw)
In-Reply-To: <1455014266-17190-1-git-send-email-zhangshengju@cmss.chinamobile.com>
From: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Date: Tue, 9 Feb 2016 10:37:46 +0000
> Replace 'goto' with 'return' to remove unnecessary check at label:
> err_undo_flags.
>
> The reason is that 'err_undo_flags' do two things for the first slave device:
> 1.revert bond mac address if it is set by the slave device.
> 2.revert bond device type if it's not ARPHRD_ETHER.
>
> It's not necessary for the following three places, they changed neither bond
> mac address nor type. It's straightforward to return directly.
>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Applied, thanks.
prev parent reply other threads:[~2016-02-11 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 10:37 [net-next v2] bonding: use return instead of goto Zhang Shengju
2016-02-11 14:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211.095724.1673577316117980850.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=j.vosburgh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).