From: David Miller <davem@davemloft.net>
To: amitoj1606@gmail.com
Cc: derek.chickles@caviumnetworks.com,
satananda.burla@caviumnetworks.com,
felix.manlunas@caviumnetworks.com,
raghu.vatsavayi@caviumnetworks.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, julia.lawall@lip6.fr
Subject: Re: [PATCH 1/3] net: cavium: liquidio: Return correct error code
Date: Sat, 13 Feb 2016 05:58:21 -0500 (EST) [thread overview]
Message-ID: <20160213.055821.121289885645162222.davem@davemloft.net> (raw)
In-Reply-To: <20160204135512.GA8297@amitoj-Inspiron-3542>
From: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Date: Thu, 4 Feb 2016 19:25:13 +0530
> The return value of vmalloc on failure of allocation of memory should
> be -ENOMEM and not -1.
>
> Found using Coccinelle. A simplified version of the semantic patch
> used is:
...
> The single call site of the containing function checks whether the
> returned value is -1, so this check is changed as well. The single call
> site of this call site, however, only checks whether the value is not 0,
> so no further change was required.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Applied.
prev parent reply other threads:[~2016-02-13 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 13:55 [PATCH 1/3] net: cavium: liquidio: Return correct error code Amitoj Kaur Chawla
2016-02-13 10:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160213.055821.121289885645162222.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amitoj1606@gmail.com \
--cc=derek.chickles@caviumnetworks.com \
--cc=felix.manlunas@caviumnetworks.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@caviumnetworks.com \
--cc=satananda.burla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox