Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: amitoj1606@gmail.com
Cc: tlfalcon@linux.vnet.ibm.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, julia.lawall@lip6.fr
Subject: Re: [PATCH 2/3] ibmveth: Return correct error codes
Date: Sat, 13 Feb 2016 05:58:44 -0500 (EST)	[thread overview]
Message-ID: <20160213.055844.351786875045113025.davem@davemloft.net> (raw)
In-Reply-To: <20160204135519.GA8362@amitoj-Inspiron-3542>

From: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Date: Thu, 4 Feb 2016 19:25:19 +0530

> The return value of kmalloc and kcalloc on failure of allocation of
> memory should be -ENOMEM and not -1.
> 
> Found using Coccinelle. A simplified version of the semantic patch
> used is:
 ...
> The two call sites only check that the return value is not 0,
> hence no change is required at the call sites.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>

This does not apply cleanly and gives rejects.

      reply	other threads:[~2016-02-13 10:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04 13:55 [PATCH 2/3] ibmveth: Return correct error codes Amitoj Kaur Chawla
2016-02-13 10:58 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160213.055844.351786875045113025.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=amitoj1606@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tlfalcon@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox