From: Jiri Benc <jbenc@redhat.com>
To: Brian Russell <brussell@brocade.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2 2/2] vxlan: support GPE/NSH
Date: Mon, 15 Feb 2016 17:49:17 +0100 [thread overview]
Message-ID: <20160215174917.025b066c@griffin> (raw)
In-Reply-To: <1455220626-28244-3-git-send-email-brussell@brocade.com>
On Thu, 11 Feb 2016 19:57:06 +0000, Brian Russell wrote:
> +skip_l2:
> skb_reset_network_header(skb);
> +
> /* In flow-based mode, GBP is carried in dst_metadata */
> - if (!(vs->flags & VXLAN_F_COLLECT_METADATA))
> + if (!(vs->flags & VXLAN_F_COLLECT_METADATA) &&
> + !(vs->flags & VXLAN_F_GPE))
> skb->mark = md->gbp;
This is completely wrong. You cannot return a packet with a garbage in
place of the Ethernet header from ARPHRD_ETHER interface. For proper
VXLAN-GPE support, the vxlan interface needs to be in L3 mode, e.g.
ARPHRD_NONE.
To support L3 mode, the vxlan driver needs *tons* of cleanups (or tons
of duplicate code). This is exactly what I've done and what I'm in
process of merging. The number of patches is too big to be submitted as
a single patchset, hence I'm submitting in parts. The first one has
been already merged (net-next commit 19f76f63507f). For the full code,
look at: https://github.com/jbenc/linux-vxlan/commits/master
Comments are welcome.
Jiri
--
Jiri Benc
next prev parent reply other threads:[~2016-02-15 16:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 19:57 [PATCH net-next v2 0/2] NSH and VxLAN-GPE Brian Russell
2016-02-11 19:57 ` [PATCH net-next v2 1/2] nsh: encapsulation module Brian Russell
2016-02-15 17:01 ` Jiri Benc
2016-03-01 11:11 ` Brian Russell
2016-02-17 3:31 ` Alexei Starovoitov
2016-03-01 11:11 ` Brian Russell
2016-02-11 19:57 ` [PATCH net-next v2 2/2] vxlan: support GPE/NSH Brian Russell
2016-02-15 16:49 ` Jiri Benc [this message]
2016-03-01 11:10 ` Brian Russell
2016-03-01 18:20 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215174917.025b066c@griffin \
--to=jbenc@redhat.com \
--cc=brussell@brocade.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).