From: Clemens Gruber <clemens.gruber@pqgruber.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] phy: marvell: Fix and unify reg-init behavior
Date: Mon, 15 Feb 2016 21:14:35 +0100 [thread overview]
Message-ID: <20160215201435.GA12064@archie.tuxnet.lan> (raw)
In-Reply-To: <56C21756.1020702@gmail.com>
Hi Florian,
On Mon, Feb 15, 2016 at 10:22:14AM -0800, Florian Fainelli wrote:
>
>
> On 15/02/2016 10:19, Florian Fainelli wrote:
> > On 15/02/2016 09:52, Clemens Gruber wrote:
> >> For the Marvell 88E1510, marvell_of_reg_init was called too late (in
> >> m88e1510_config_aneg), which lead to the phy state machine being stuck
> >> at waiting for interrupts, which are off by default on the 88E1510.
> >> This further lead to the ethernet link not coming up at boot.
> >> For some Marvell PHYs, marvell_of_reg_init was not called at all.
> >
> > You could mention that this became apparent with
>
> ...
> 113c74d83eef ("net: phy: turn carrier off on phy attach")
Thanks for your comments. I thought it would be better to just leave all
PHYs with special requirements (resets, ..) as they were and only change
the behavior of those who were missing the marvell_of_reg_init calls.
What do you think?
Clemens
prev parent reply other threads:[~2016-02-15 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 17:52 [PATCH] phy: marvell: Fix and unify reg-init behavior Clemens Gruber
2016-02-15 18:19 ` Florian Fainelli
2016-02-15 18:22 ` Florian Fainelli
2016-02-15 20:14 ` Clemens Gruber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215201435.GA12064@archie.tuxnet.lan \
--to=clemens.gruber@pqgruber.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).