From mboxrd@z Thu Jan 1 00:00:00 1970 From: Clemens Gruber Subject: Re: [PATCH v2] phy: marvell: Fix and unify reg-init behavior Date: Mon, 15 Feb 2016 23:34:24 +0100 Message-ID: <20160215223423.GA836@archie.tuxnet.lan> References: <1455566460-31291-1-git-send-email-clemens.gruber@pqgruber.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "netdev@vger.kernel.org" , Florian Fainelli , linux-kernel , "David S . Miller" , Andrew Lunn To: Fabio Estevam Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Fabio, On Mon, Feb 15, 2016 at 06:54:29PM -0200, Fabio Estevam wrote: > On Mon, Feb 15, 2016 at 6:01 PM, Clemens Gruber > wrote: > > > +static int marvell_config_init(struct phy_device *phydev) > > +{ > > + int err; > > + > > + /* Set registers from marvell,reg-init DT property */ > > + err = marvell_of_reg_init(phydev); > > + if (err < 0) > > + return err; > > + > > + return 0; > > } > > Couldn't this be replaced by > > return marvell_of_reg_init(phydev); ? I wanted to add some missing errata fixes from the Marvell Release Notes into that function (in the near future). But you are right, I should probably not change things preemptively. I'll send a v3 with that part replaced! Thanks, Clemens