From: David Miller <davem@davemloft.net>
To: gerlitz.or@gmail.com
Cc: john.fastabend@gmail.com, amir@vadai.me, jhs@mojatatu.com,
netdev@vger.kernel.org, jiri@resnulli.us,
jeffrey.t.kirsher@intel.com
Subject: Re: [net-next PATCH v2 0/8] tc offload for cls_u32 on ixgbe
Date: Tue, 16 Feb 2016 14:50:55 -0500 (EST) [thread overview]
Message-ID: <20160216.145055.1581160555302651949.davem@davemloft.net> (raw)
In-Reply-To: <CAJ3xEMhqHbHDH06O5+Y_2mNQM3BNVA9bCLBS70ZK+=-6upDtaA@mail.gmail.com>
From: Or Gerlitz <gerlitz.or@gmail.com>
Date: Tue, 16 Feb 2016 21:30:18 +0200
> On Tue, Feb 16, 2016 at 8:00 AM, John Fastabend
> <john.fastabend@gmail.com> wrote:
> [...]
>
>> Specifically this uses a 'big hammer' feature bit
>> to do the offload or not. If the bit is set you get offloaded rules
>> if it is not then rules will not be offloaded. If we can agree on
>> this patch series there are some more patches on my queue we can
>> talk about to make the offload decision per rule using flags similar
>> to how we do l2 mac updates. Additionally the error strategy can
>> be improved to be hard aborting, log and continue, etc. I think
>> these are nice to have improvements but shouldn't block this series.
>
> John,
>
> I thought we've got into agreement in netdev that the offloading
> directive would be a tri-state creature (sw, hw and fail the op if
> can't, hw and fallback to sw). Can you please elaborate what do you
> mean by "make the offload decision per rule using flags similar to how
> we do l2 mac updates"
I think John's changes are an intermediate step in a long term
evoluation.
I'm going to apply John's changes as-is, and people can submit relative
changes on top if they want.
next prev parent reply other threads:[~2016-02-16 19:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 6:00 [net-next PATCH v2 0/8] tc offload for cls_u32 on ixgbe John Fastabend
2016-02-16 6:00 ` [net-next PATCH v2 1/8] net: rework ndo tc op to consume additional qdisc handle parameter John Fastabend
2016-02-16 20:15 ` Jiri Pirko
2016-02-16 6:00 ` [net-next PATCH v2 2/8] net: rework setup_tc ndo op to consume general tc operand John Fastabend
2016-02-16 20:17 ` Jiri Pirko
2016-02-28 14:11 ` Alaa Hleihel
2016-02-16 6:01 ` [net-next PATCH v2 3/8] net: sched: add cls_u32 offload hooks for netdevs John Fastabend
2016-02-16 20:20 ` Jiri Pirko
2016-02-17 3:21 ` John Fastabend
2016-02-16 6:01 ` [net-next PATCH v2 4/8] net: add tc offload feature flag John Fastabend
2016-02-16 20:22 ` Jiri Pirko
2016-02-16 6:02 ` [net-next PATCH v2 5/8] net: tc: helper functions to query action types John Fastabend
2016-02-16 20:26 ` Jiri Pirko
2016-02-17 3:21 ` John Fastabend
2016-02-16 6:02 ` [net-next PATCH v2 6/8] net: ixgbe: add minimal parser details for ixgbe John Fastabend
2016-02-16 6:03 ` [net-next PATCH v2 7/8] net: ixgbe: add support for tc_u32 offload John Fastabend
2016-02-16 6:03 ` [net-next PATCH v2 8/8] net: ixgbe: abort with cls u32 divisor groups greater than 1 John Fastabend
2016-02-16 19:30 ` [net-next PATCH v2 0/8] tc offload for cls_u32 on ixgbe Or Gerlitz
2016-02-16 19:50 ` David Miller [this message]
2016-02-16 20:46 ` Or Gerlitz
2016-02-17 1:17 ` David Miller
2016-02-17 5:23 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216.145055.1581160555302651949.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amir@vadai.me \
--cc=gerlitz.or@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).