From: David Miller <davem@davemloft.net>
To: grygorii.strashko@ti.com
Cc: netdev@vger.kernel.org, arnd@arndb.de, fcooper@ti.com,
nsekhar@ti.com, linux-kernel@vger.kernel.org, w-kwok2@ti.com,
m-karicheri2@ti.com, mugunthanvnm@ti.com
Subject: Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality
Date: Tue, 16 Feb 2016 15:24:21 -0500 (EST) [thread overview]
Message-ID: <20160216.152421.2271194730635382792.davem@davemloft.net> (raw)
In-Reply-To: <1455026303-17014-1-git-send-email-grygorii.strashko@ti.com>
I would like some of the feedback to be taken into consideration and
integrated into this patch.
Part of the reason this regression was introduced was probably because
the purpose of some fields or descriptor semantics was not defined
properly.
Therefore it is absolutely appropriate to properly name and document
these fields as part of the bug fix.
Thank you.
next prev parent reply other threads:[~2016-02-16 20:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 13:58 [PATCH] net: ti: netcp: restore get/set_pad_info() functionality Grygorii Strashko
2016-02-09 14:13 ` David Laight
2016-02-09 16:09 ` Karicheri, Muralidharan
2016-02-09 16:10 ` David Laight
2016-02-09 16:19 ` Karicheri, Muralidharan
2016-02-09 16:37 ` David Laight
2016-02-09 16:55 ` Karicheri, Muralidharan
2016-02-09 19:38 ` Arnd Bergmann
2016-02-10 8:33 ` Grygorii Strashko
2016-02-17 16:19 ` Murali Karicheri
2016-02-18 17:02 ` Murali Karicheri
2016-02-16 20:24 ` David Miller [this message]
2016-02-18 17:13 ` Murali Karicheri
2016-02-18 20:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216.152421.2271194730635382792.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=fcooper@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=w-kwok2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).