From: David Miller <davem@davemloft.net>
To: equinox@diac24.net
Cc: dsa@cumulusnetworks.com, netdev@vger.kernel.org,
david@opensourcerouting.org
Subject: Re: [net-next] net: l3mdev: address selection should only consider devices in L3 domain
Date: Tue, 16 Feb 2016 20:05:18 -0500 (EST) [thread overview]
Message-ID: <20160216.200518.1495764396935534189.davem@davemloft.net> (raw)
In-Reply-To: <20160216234115.GI659150@eidolon>
From: David Lamparter <equinox@diac24.net>
Date: Wed, 17 Feb 2016 00:41:15 +0100
> ... this won't do enough. If you look at the 4.3 patch I sent you, I
> was adding a comment:
>
> + /* For VRFs, the VRF device takes the place of the loopback device,
> + with addresses on it being preferred. Note in such cases the
> + loopback device will be among the devices that fail the vrf_ifi
> + equality check in the loop below.
> + */
I know that some parts of of net/ipv4/devinet.c uses this comment
style, it is not correct for new networking code. Therefore,
please update your patch to use the proper style:
/* Like
* this.
*/
Thanks.
prev parent reply other threads:[~2016-02-17 1:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 22:59 [net-next] net: l3mdev: address selection should only consider devices in L3 domain David Ahern
2016-02-16 23:41 ` David Lamparter
2016-02-16 23:48 ` [net-next] net: l3mdev: prefer VRF master for source address selection David Lamparter
2016-02-16 23:49 ` [net-next] net: l3mdev: address selection should only consider devices in L3 domain David Ahern
2016-02-17 1:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216.200518.1495764396935534189.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david@opensourcerouting.org \
--cc=dsa@cumulusnetworks.com \
--cc=equinox@diac24.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).