From: David Miller <davem@davemloft.net>
To: ben@decadent.org.uk
Cc: rweikusat@mobileactivedefense.com, hannes@stressinduktion.org,
edumazet@google.com, dhowells@redhat.com, ying.xue@windriver.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, joseph.salisbury@canonical.com
Subject: Re: [PATCH] af_unix: Don't set err in unix_stream_read_generic unless there was an error
Date: Tue, 16 Feb 2016 20:07:03 -0500 (EST) [thread overview]
Message-ID: <20160216.200703.2116723624769185830.davem@davemloft.net> (raw)
In-Reply-To: <1455668691.1143.18.camel@decadent.org.uk>
From: Ben Hutchings <ben@decadent.org.uk>
Date: Wed, 17 Feb 2016 00:24:51 +0000
> I agree that 'if (err) goto cleanup;' is widely used and is generally
> understandable (though more creative uses of goto are often not).
>
> My objection was to 'err = -EFOO; if (cond) goto cleanup;'. That is
> definitely not clear and it hides mistakes like this.
I don't see any difference whatsoever.
Part of the convention of the cleanup blob at the end of the
function is that error propagate to it's return statement via
a variable.
If this code wanted to handle that in more than one way, it is
the problem of this function, not of the convention itself.
next prev parent reply other threads:[~2016-02-17 1:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 18:50 [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code Joseph Salisbury
2016-02-05 19:59 ` Rainer Weikusat
2016-02-05 20:06 ` Joseph Salisbury
2016-02-05 21:18 ` Rainer Weikusat
2016-02-05 22:04 ` Rainer Weikusat
2016-02-05 21:44 ` Rainer Weikusat
2016-02-05 23:03 ` Eric Dumazet
2016-02-07 18:43 ` Rainer Weikusat
2016-02-07 20:39 ` Rainer Weikusat
2016-02-07 22:24 ` Rainer Weikusat
2016-02-08 3:35 ` Eric Dumazet
2016-02-05 22:30 ` [PATCH] af_unix: Don't set err in unix_stream_read_generic unless there was an error Rainer Weikusat
2016-02-07 19:20 ` Rainer Weikusat
2016-02-08 15:33 ` Rainer Weikusat
2016-02-08 18:05 ` Rainer Weikusat
2016-02-08 18:47 ` Rainer Weikusat
2016-02-16 17:51 ` David Miller
2016-02-17 0:24 ` Ben Hutchings
2016-02-17 1:07 ` David Miller [this message]
2016-02-08 18:33 ` Sergei Shtylyov
2016-02-11 21:31 ` Joseph Salisbury
2016-02-12 13:31 ` Rainer Weikusat
2016-02-13 0:18 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216.200703.2116723624769185830.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=joseph.salisbury@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rweikusat@mobileactivedefense.com \
--cc=stable@vger.kernel.org \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).