From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [net-next PATCH v3 6/8] net: ixgbe: add minimal parser details for ixgbe Date: Wed, 17 Feb 2016 10:09:06 -0500 (EST) Message-ID: <20160217.100906.816402468592090571.davem@davemloft.net> References: <20160217051418.17139.41052.stgit@john-Precision-Tower-5810> <20160217051828.17139.51653.stgit@john-Precision-Tower-5810> <56C4541A.5070508@mojatatu.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: john.fastabend@gmail.com, jiri@resnulli.us, amir@vadai.me, netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com To: jhs@mojatatu.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:53017 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423774AbcBQPJI (ORCPT ); Wed, 17 Feb 2016 10:09:08 -0500 In-Reply-To: <56C4541A.5070508@mojatatu.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jamal Hadi Salim Date: Wed, 17 Feb 2016 06:06:02 -0500 > On 16-02-17 12:18 AM, John Fastabend wrote: >> This adds an ixgbe data structure that is used to determine what >> headers:fields can be matched and in what order they are supported. >> >> For hardware devices this can be a bit tricky because typically >> only pre-programmed (firmware, ucode, rtl) parse graphs will be >> supported and we don't yet have an interface to change these from >> the OS. So its sort of a you get whatever your friendly vendor >> provides affair at the moment. >> >> In the future we can add the get routines and set routines to >> update this data structure. One interesting thing to note here >> is the data structure here identifies ethernet, ip, and tcp >> fields without having to hardcode them as enumerations or use >> other identifiers. >> >> Signed-off-by: John Fastabend > > > should __u32 be u32? Also at some points you seem to interchangeably > use unsigned int vs u32. I think most of unsigned ints should be u32. Anything only kernel visible should be 'u32', whereas if the object is exported via a uapi header file it should be '__u32'.