From: David Miller <davem@davemloft.net>
To: drivshin.allworx@gmail.com
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org, mugunthanvnm@ti.com,
kwizart@gmail.com
Subject: Re: [PATCH] drivers: net: cpsw-phy-sel: add dev_warn() for unsupported PHY mode
Date: Wed, 17 Feb 2016 10:51:04 -0500 (EST) [thread overview]
Message-ID: <20160217.105104.143723229571677119.davem@davemloft.net> (raw)
In-Reply-To: <1455324336-3884-1-git-send-email-drivshin.allworx@gmail.com>
From: "David Rivshin (Allworx)" <drivshin.allworx@gmail.com>
Date: Fri, 12 Feb 2016 19:45:36 -0500
> From: David Rivshin <drivshin@allworx.com>
>
> The cpsw-phy-sel driver supports only MII, RMII, and RGMII PHY modes,
> and silently handled any other values as if MII was specified. In a
> case where the PHY mode was incorrectly specified, or a bug elsewhere,
> there would be no indication of a problem. If MII was the correct mode,
> then this will go unnoticed, otherwise the symptom will be a failure
> to transmit/receive data over the RMII/RGMII link.
>
> Add a dev_warn() to make this condition obvious and provide a
> breadcrumb to follow.
>
> Cc: Mugunthan V N <mugunthanvnm@ti.com>
> Signed-off-by: David Rivshin <drivshin@allworx.com>
Applied to 'net', thanks. I don't think I'll queue this up for -stable.
Thanks.
prev parent reply other threads:[~2016-02-17 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 0:45 [PATCH] drivers: net: cpsw-phy-sel: add dev_warn() for unsupported PHY mode David Rivshin (Allworx)
2016-02-15 6:15 ` Mugunthan V N
2016-02-17 15:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217.105104.143723229571677119.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=drivshin.allworx@gmail.com \
--cc=kwizart@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).