* [net-next PATCH 1/2] ixgbe: use u32 instead of __u32 in model header
@ 2016-02-17 22:34 John Fastabend
2016-02-17 22:35 ` [net-next PATCH 2/2] ixgbe: fix dates on header of ixgbe_model.h John Fastabend
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: John Fastabend @ 2016-02-17 22:34 UTC (permalink / raw)
To: john.fastabend, jhs, jeffrey.t.kirsher; +Cc: netdev, davem
I incorrectly used __u32 types where we should be using u32 types when
I added the ixgbe_model.h file.
Fixes: 9d35cf062e05 ("net: ixgbe: add minimal parser details for ixgbe")
Suggested-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_model.h | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_model.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_model.h
index 43ebec4..62ea2e7 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_model.h
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_model.h
@@ -35,13 +35,13 @@ struct ixgbe_mat_field {
unsigned int mask;
int (*val)(struct ixgbe_fdir_filter *input,
union ixgbe_atr_input *mask,
- __u32 val, __u32 m);
+ u32 val, u32 m);
unsigned int type;
};
static inline int ixgbe_mat_prgm_sip(struct ixgbe_fdir_filter *input,
union ixgbe_atr_input *mask,
- __u32 val, __u32 m)
+ u32 val, u32 m)
{
input->filter.formatted.src_ip[0] = val;
mask->formatted.src_ip[0] = m;
@@ -50,7 +50,7 @@ static inline int ixgbe_mat_prgm_sip(struct ixgbe_fdir_filter *input,
static inline int ixgbe_mat_prgm_dip(struct ixgbe_fdir_filter *input,
union ixgbe_atr_input *mask,
- __u32 val, __u32 m)
+ u32 val, u32 m)
{
input->filter.formatted.dst_ip[0] = val;
mask->formatted.dst_ip[0] = m;
@@ -67,7 +67,7 @@ static struct ixgbe_mat_field ixgbe_ipv4_fields[] = {
static inline int ixgbe_mat_prgm_sport(struct ixgbe_fdir_filter *input,
union ixgbe_atr_input *mask,
- __u32 val, __u32 m)
+ u32 val, u32 m)
{
input->filter.formatted.src_port = val & 0xffff;
mask->formatted.src_port = m & 0xffff;
@@ -76,7 +76,7 @@ static inline int ixgbe_mat_prgm_sport(struct ixgbe_fdir_filter *input,
static inline int ixgbe_mat_prgm_dport(struct ixgbe_fdir_filter *input,
union ixgbe_atr_input *mask,
- __u32 val, __u32 m)
+ u32 val, u32 m)
{
input->filter.formatted.dst_port = val & 0xffff;
mask->formatted.dst_port = m & 0xffff;
@@ -94,12 +94,12 @@ static struct ixgbe_mat_field ixgbe_tcp_fields[] = {
struct ixgbe_nexthdr {
/* offset, shift, and mask of position to next header */
unsigned int o;
- __u32 s;
- __u32 m;
+ u32 s;
+ u32 m;
/* match criteria to make this jump*/
unsigned int off;
- __u32 val;
- __u32 mask;
+ u32 val;
+ u32 mask;
/* location of jump to make */
struct ixgbe_mat_field *jump;
};
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [net-next PATCH 2/2] ixgbe: fix dates on header of ixgbe_model.h
2016-02-17 22:34 [net-next PATCH 1/2] ixgbe: use u32 instead of __u32 in model header John Fastabend
@ 2016-02-17 22:35 ` John Fastabend
2016-02-17 22:42 ` Jeff Kirsher
2016-02-18 2:44 ` David Miller
2016-02-17 22:41 ` [net-next PATCH 1/2] ixgbe: use u32 instead of __u32 in model header Jeff Kirsher
2016-02-18 2:44 ` David Miller
2 siblings, 2 replies; 7+ messages in thread
From: John Fastabend @ 2016-02-17 22:35 UTC (permalink / raw)
To: john.fastabend, jhs, jeffrey.t.kirsher; +Cc: netdev, davem
Fixes: 9d35cf062e05 ("net: ixgbe: add minimal parser details for ixgbe")
Reported-by: Mark Rustad <mark.d.rustad@intel.com>
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_model.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_model.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_model.h
index 62ea2e7..ce48872 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_model.h
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_model.h
@@ -1,7 +1,7 @@
/*******************************************************************************
*
* Intel 10 Gigabit PCI Express Linux drive
- * Copyright(c) 2013 - 2015 Intel Corporation.
+ * Copyright(c) 2016 Intel Corporation.
*
* This program is free software; you can redistribute it and/or modify it
* under the terms and conditions of the GNU General Public License,
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [net-next PATCH 1/2] ixgbe: use u32 instead of __u32 in model header
2016-02-17 22:34 [net-next PATCH 1/2] ixgbe: use u32 instead of __u32 in model header John Fastabend
2016-02-17 22:35 ` [net-next PATCH 2/2] ixgbe: fix dates on header of ixgbe_model.h John Fastabend
@ 2016-02-17 22:41 ` Jeff Kirsher
2016-02-18 2:23 ` David Miller
2016-02-18 2:44 ` David Miller
2 siblings, 1 reply; 7+ messages in thread
From: Jeff Kirsher @ 2016-02-17 22:41 UTC (permalink / raw)
To: John Fastabend, jhs; +Cc: netdev, davem
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On Wed, 2016-02-17 at 14:34 -0800, John Fastabend wrote:
> I incorrectly used __u32 types where we should be using u32 types
> when
> I added the ixgbe_model.h file.
>
> Fixes: 9d35cf062e05 ("net: ixgbe: add minimal parser details for
> ixgbe")
> Suggested-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_model.h | 18 +++++++++-----
> ----
> 1 file changed, 9 insertions(+), 9 deletions(-)
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Dave feel free to pull this series in from John to fix the issues with
his previous series.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [net-next PATCH 2/2] ixgbe: fix dates on header of ixgbe_model.h
2016-02-17 22:35 ` [net-next PATCH 2/2] ixgbe: fix dates on header of ixgbe_model.h John Fastabend
@ 2016-02-17 22:42 ` Jeff Kirsher
2016-02-18 2:44 ` David Miller
1 sibling, 0 replies; 7+ messages in thread
From: Jeff Kirsher @ 2016-02-17 22:42 UTC (permalink / raw)
To: John Fastabend, jhs; +Cc: netdev, davem
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
On Wed, 2016-02-17 at 14:35 -0800, John Fastabend wrote:
> Fixes: 9d35cf062e05 ("net: ixgbe: add minimal parser details for
> ixgbe")
> Reported-by: Mark Rustad <mark.d.rustad@intel.com>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_model.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [net-next PATCH 1/2] ixgbe: use u32 instead of __u32 in model header
2016-02-17 22:41 ` [net-next PATCH 1/2] ixgbe: use u32 instead of __u32 in model header Jeff Kirsher
@ 2016-02-18 2:23 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2016-02-18 2:23 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: john.fastabend, jhs, netdev
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 17 Feb 2016 14:41:48 -0800
> On Wed, 2016-02-17 at 14:34 -0800, John Fastabend wrote:
>> I incorrectly used __u32 types where we should be using u32 types
>> when
>> I added the ixgbe_model.h file.
>>
>> Fixes: 9d35cf062e05 ("net: ixgbe: add minimal parser details for
>> ixgbe")
>> Suggested-by: Jamal Hadi Salim <jhs@mojatatu.com>
>> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
>> ---
>> drivers/net/ethernet/intel/ixgbe/ixgbe_model.h | 18 +++++++++-----
>> ----
>> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>
> Dave feel free to pull this series in from John to fix the issues with
> his previous series.
Will do.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [net-next PATCH 1/2] ixgbe: use u32 instead of __u32 in model header
2016-02-17 22:34 [net-next PATCH 1/2] ixgbe: use u32 instead of __u32 in model header John Fastabend
2016-02-17 22:35 ` [net-next PATCH 2/2] ixgbe: fix dates on header of ixgbe_model.h John Fastabend
2016-02-17 22:41 ` [net-next PATCH 1/2] ixgbe: use u32 instead of __u32 in model header Jeff Kirsher
@ 2016-02-18 2:44 ` David Miller
2 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2016-02-18 2:44 UTC (permalink / raw)
To: john.fastabend; +Cc: jhs, jeffrey.t.kirsher, netdev
From: John Fastabend <john.fastabend@gmail.com>
Date: Wed, 17 Feb 2016 14:34:53 -0800
> I incorrectly used __u32 types where we should be using u32 types when
> I added the ixgbe_model.h file.
>
> Fixes: 9d35cf062e05 ("net: ixgbe: add minimal parser details for ixgbe")
> Suggested-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [net-next PATCH 2/2] ixgbe: fix dates on header of ixgbe_model.h
2016-02-17 22:35 ` [net-next PATCH 2/2] ixgbe: fix dates on header of ixgbe_model.h John Fastabend
2016-02-17 22:42 ` Jeff Kirsher
@ 2016-02-18 2:44 ` David Miller
1 sibling, 0 replies; 7+ messages in thread
From: David Miller @ 2016-02-18 2:44 UTC (permalink / raw)
To: john.fastabend; +Cc: jhs, jeffrey.t.kirsher, netdev
From: John Fastabend <john.fastabend@gmail.com>
Date: Wed, 17 Feb 2016 14:35:23 -0800
> Fixes: 9d35cf062e05 ("net: ixgbe: add minimal parser details for ixgbe")
> Reported-by: Mark Rustad <mark.d.rustad@intel.com>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-02-18 2:44 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-17 22:34 [net-next PATCH 1/2] ixgbe: use u32 instead of __u32 in model header John Fastabend
2016-02-17 22:35 ` [net-next PATCH 2/2] ixgbe: fix dates on header of ixgbe_model.h John Fastabend
2016-02-17 22:42 ` Jeff Kirsher
2016-02-18 2:44 ` David Miller
2016-02-17 22:41 ` [net-next PATCH 1/2] ixgbe: use u32 instead of __u32 in model header Jeff Kirsher
2016-02-18 2:23 ` David Miller
2016-02-18 2:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).