* [PATCH net] vxlan: clear IFF_TX_SKB_SHARING @ 2016-02-16 21:16 Jiri Benc 2016-02-17 0:04 ` Jesse Gross 2016-02-18 19:55 ` David Miller 0 siblings, 2 replies; 4+ messages in thread From: Jiri Benc @ 2016-02-16 21:16 UTC (permalink / raw) To: netdev ether_setup sets IFF_TX_SKB_SHARING but this is not supported by vxlan as it modifies the skb on xmit. Signed-off-by: Jiri Benc <jbenc@redhat.com> --- drivers/net/vxlan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index a31cd954b308..db96f3a16f6c 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -2537,6 +2537,7 @@ static void vxlan_setup(struct net_device *dev) dev->hw_features |= NETIF_F_GSO_SOFTWARE; dev->hw_features |= NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_HW_VLAN_STAG_TX; netif_keep_dst(dev); + dev->priv_flags &= ~IFF_TX_SKB_SHARING; dev->priv_flags |= IFF_LIVE_ADDR_CHANGE | IFF_NO_QUEUE; INIT_LIST_HEAD(&vxlan->next); -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] vxlan: clear IFF_TX_SKB_SHARING 2016-02-16 21:16 [PATCH net] vxlan: clear IFF_TX_SKB_SHARING Jiri Benc @ 2016-02-17 0:04 ` Jesse Gross 2016-02-17 9:53 ` Jiri Benc 2016-02-18 19:55 ` David Miller 1 sibling, 1 reply; 4+ messages in thread From: Jesse Gross @ 2016-02-17 0:04 UTC (permalink / raw) To: Jiri Benc; +Cc: Linux Kernel Network Developers On Tue, Feb 16, 2016 at 1:16 PM, Jiri Benc <jbenc@redhat.com> wrote: > ether_setup sets IFF_TX_SKB_SHARING but this is not supported by vxlan as it > modifies the skb on xmit. > > Signed-off-by: Jiri Benc <jbenc@redhat.com> Presumably this is something that should be done on all tunnels that can carry Ethernet frames, right? ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] vxlan: clear IFF_TX_SKB_SHARING 2016-02-17 0:04 ` Jesse Gross @ 2016-02-17 9:53 ` Jiri Benc 0 siblings, 0 replies; 4+ messages in thread From: Jiri Benc @ 2016-02-17 9:53 UTC (permalink / raw) To: Jesse Gross; +Cc: Linux Kernel Network Developers On Tue, 16 Feb 2016 16:04:33 -0800, Jesse Gross wrote: > Presumably this is something that should be done on all tunnels that > can carry Ethernet frames, right? Geneve and GRE likely need the same fix, yes. I think the fixes for them should be sent as separate patches. Jiri -- Jiri Benc ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] vxlan: clear IFF_TX_SKB_SHARING 2016-02-16 21:16 [PATCH net] vxlan: clear IFF_TX_SKB_SHARING Jiri Benc 2016-02-17 0:04 ` Jesse Gross @ 2016-02-18 19:55 ` David Miller 1 sibling, 0 replies; 4+ messages in thread From: David Miller @ 2016-02-18 19:55 UTC (permalink / raw) To: jbenc; +Cc: netdev From: Jiri Benc <jbenc@redhat.com> Date: Tue, 16 Feb 2016 22:16:53 +0100 > ether_setup sets IFF_TX_SKB_SHARING but this is not supported by vxlan as it > modifies the skb on xmit. > > Signed-off-by: Jiri Benc <jbenc@redhat.com> Applied. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-18 19:55 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-02-16 21:16 [PATCH net] vxlan: clear IFF_TX_SKB_SHARING Jiri Benc 2016-02-17 0:04 ` Jesse Gross 2016-02-17 9:53 ` Jiri Benc 2016-02-18 19:55 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).