netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] Add support for PHY packet generators
Date: Thu, 18 Feb 2016 15:45:39 -0500 (EST)	[thread overview]
Message-ID: <20160218.154539.340432973192973342.davem@davemloft.net> (raw)
In-Reply-To: <1455741127-25453-1-git-send-email-andrew@lunn.ch>

From: Andrew Lunn <andrew@lunn.ch>
Date: Wed, 17 Feb 2016 21:32:05 +0100

> Some Ethernet PHYs contain a simple packet generator. This can be
> useful for bringing up new devices, trying to determine if a problem
> lies in the MAC-PHY connection or PHY-Socket. Also, the PHY generators
> can generate invalid packets, which is hard to do in software.
> 
> Add support ethtool(1) and wire up the Marvell PHY packet generator.

You really cannot make this blocking, every time we've added a blocking
ethtool op that could take a non-trivial amount of time we've been
burnt.

So as Ben mentioned blocking for 0.3 seconds or whatever is a non-starter.

      parent reply	other threads:[~2016-02-18 20:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 20:32 [PATCH net-next 0/2] Add support for PHY packet generators Andrew Lunn
2016-02-17 20:32 ` [PATCH net-next 1/2] net: ethtool: " Andrew Lunn
2016-02-17 21:06   ` Ben Hutchings
2016-02-17 21:55     ` Andrew Lunn
2016-02-17 23:28       ` Ben Hutchings
2016-02-17 20:32 ` [PATCH net-next 2/2] phy: marvell: Add support for phy packet generator Andrew Lunn
2016-02-17 22:33   ` Lino Sanfilippo
2016-02-17 23:49   ` Florian Fainelli
2016-02-18 20:45 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160218.154539.340432973192973342.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).