From: Simon Horman <horms@verge.net.au>
To: Corcodel Marian <asd@marian1000.go.ro>
Cc: netdev@vger.kernel.org
Subject: Re: [net] r8169 Remove duplicate command which set RxVlan and RxChksum bits.
Date: Thu, 18 Feb 2016 14:25:43 +0900 [thread overview]
Message-ID: <20160218052543.GA15955@verge.net.au> (raw)
In-Reply-To: <1454254388-15523-1-git-send-email-asd@marian1000.go.ro>
On Sun, Jan 31, 2016 at 05:33:08PM +0200, Corcodel Marian wrote:
> These bits is already set on set geatures stage.
>
> Signed-off-by: Corcodel Marian <asd@marian1000.go.ro>
> ---
> drivers/net/ethernet/realtek/r8169.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 17d5571..a8fb86d 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -8368,7 +8368,6 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> dev->vlan_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO |
> NETIF_F_HIGHDMA;
>
> - tp->cp_cmd |= RxChkSum | RxVlan;
>
To avoid two consecutive blank lines, which seems excessive here,
you may want to consider removing the blank line before or after the
line of code you are removing.
> /*
> * Pretend we are using VLANs; This bypasses a nasty bug where
> --
> 2.5.0
>
prev parent reply other threads:[~2016-02-18 5:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 15:33 [net] r8169 Remove duplicate command which set RxVlan and RxChksum bits Corcodel Marian
2016-01-31 17:17 ` Sergei Shtylyov
2016-01-31 17:17 ` Sergei Shtylyov
2016-02-18 5:25 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218052543.GA15955@verge.net.au \
--to=horms@verge.net.au \
--cc=asd@marian1000.go.ro \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).