From: Stephen Hemminger <stephen@networkplumber.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, sgunderson@bigfoot.com,
tom@herbertland.com
Subject: Re: [PATCH] net: fix bridge multicast packet checksum validation
Date: Thu, 18 Feb 2016 17:38:25 -0800 [thread overview]
Message-ID: <20160218173825.3dca8d27@xeon-e3> (raw)
In-Reply-To: <20160218.153542.67284853154438064.davem@davemloft.net>
On Thu, 18 Feb 2016 15:35:42 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
> From: Linus Lüssing <linus.luessing@c0d3.blue>
> Date: Mon, 15 Feb 2016 03:07:06 +0100
>
> > @@ -4084,10 +4089,22 @@ struct sk_buff *skb_checksum_trimmed(struct sk_buff *skb,
> > if (!pskb_may_pull(skb_chk, offset))
> > goto err;
> >
> > - __skb_pull(skb_chk, offset);
> > + ip_summed = skb->ip_summed;
> > + csum_valid = skb->csum_valid;
> > + csum_level = skb->csum_level;
> > + csum_bad = skb->csum_bad;
> > + csum = skb->csum;
> > +
> > + skb_pull_rcsum(skb_chk, offset);
> > ret = skb_chkf(skb_chk);
> > __skb_push(skb_chk, offset);
> >
> > + skb->ip_summed = ip_summed;
> > + skb->csum_valid = csum_valid;
> > + skb->csum_level = csum_level;
> > + skb->csum_bad = csum_bad;
> > + skb->csum = csum;
> > +
>
> There really has to be a better way to fix this :-/
Agreed, this is gross.
prev parent reply other threads:[~2016-02-19 1:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 2:07 [PATCH] net: fix bridge multicast packet checksum validation Linus Lüssing
2016-02-18 12:51 ` Steinar H. Gunderson
2016-02-18 13:36 ` Linus Lüssing
2016-02-18 20:35 ` David Miller
2016-02-19 1:38 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218173825.3dca8d27@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgunderson@bigfoot.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).