* [PATCH] rtnl: RTM_GETNETCONF: fix wrong return value
@ 2016-02-17 2:43 Anton Protopopov
2016-02-17 22:57 ` Cong Wang
2016-02-19 20:34 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Anton Protopopov @ 2016-02-17 2:43 UTC (permalink / raw)
To: David S. Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy, netdev, linux-kernel
Cc: Anton Protopopov
An error response from a RTM_GETNETCONF request can return the positive
error value EINVAL in the struct nlmsgerr that can mislead userspace.
Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
---
net/ipv4/devinet.c | 2 +-
net/ipv6/addrconf.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index cebd9d3..f6303b1 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -1847,7 +1847,7 @@ static int inet_netconf_get_devconf(struct sk_buff *in_skb,
if (err < 0)
goto errout;
- err = EINVAL;
+ err = -EINVAL;
if (!tb[NETCONFA_IFINDEX])
goto errout;
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 9efd9ff..bdd7eac 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -583,7 +583,7 @@ static int inet6_netconf_get_devconf(struct sk_buff *in_skb,
if (err < 0)
goto errout;
- err = EINVAL;
+ err = -EINVAL;
if (!tb[NETCONFA_IFINDEX])
goto errout;
--
2.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtnl: RTM_GETNETCONF: fix wrong return value
2016-02-17 2:43 [PATCH] rtnl: RTM_GETNETCONF: fix wrong return value Anton Protopopov
@ 2016-02-17 22:57 ` Cong Wang
2016-02-19 20:34 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Cong Wang @ 2016-02-17 22:57 UTC (permalink / raw)
To: Anton Protopopov
Cc: David S. Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy,
Linux Kernel Network Developers, LKML
On Tue, Feb 16, 2016 at 6:43 PM, Anton Protopopov
<a.s.protopopov@gmail.com> wrote:
> An error response from a RTM_GETNETCONF request can return the positive
> error value EINVAL in the struct nlmsgerr that can mislead userspace.
>
> Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
LGTM,
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtnl: RTM_GETNETCONF: fix wrong return value
2016-02-17 2:43 [PATCH] rtnl: RTM_GETNETCONF: fix wrong return value Anton Protopopov
2016-02-17 22:57 ` Cong Wang
@ 2016-02-19 20:34 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-02-19 20:34 UTC (permalink / raw)
To: a.s.protopopov; +Cc: kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel
From: Anton Protopopov <a.s.protopopov@gmail.com>
Date: Tue, 16 Feb 2016 21:43:16 -0500
> An error response from a RTM_GETNETCONF request can return the positive
> error value EINVAL in the struct nlmsgerr that can mislead userspace.
>
> Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-19 20:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-17 2:43 [PATCH] rtnl: RTM_GETNETCONF: fix wrong return value Anton Protopopov
2016-02-17 22:57 ` Cong Wang
2016-02-19 20:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).