* [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6
@ 2016-02-17 18:30 Paolo Abeni
2016-02-17 19:19 ` Jesse Gross
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Paolo Abeni @ 2016-02-17 18:30 UTC (permalink / raw)
To: netdev
Cc: David S. Miller, Jesse Gross, Thomas Graf, Jiri Benc,
Pravin Shelar, Tom Herbert
the commit 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be
correctly controlled.") changed the default xmit checksum setting
for lwt vxlan/geneve ipv6 tunnels, so that now the checksum is not
set into external UDP header.
This commit changes the rx checksum setting for both lwt vxlan/geneve
devices created by openvswitch accordingly, so that lwt over ipv6
tunnel pairs are again able to communicate with default values.
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
v2: rebased against current -net
---
drivers/net/geneve.c | 3 ++-
net/openvswitch/vport-vxlan.c | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index 028e387..3496d78 100644
--- a/drivers/net/geneve.c
+++ b/drivers/net/geneve.c
@@ -1452,7 +1452,8 @@ struct net_device *geneve_dev_create_fb(struct net *net, const char *name,
return dev;
err = geneve_configure(net, dev, &geneve_remote_unspec,
- 0, 0, 0, htons(dst_port), true, 0);
+ 0, 0, 0, htons(dst_port), true,
+ GENEVE_F_UDP_ZERO_CSUM6_RX);
if (err)
goto err;
diff --git a/net/openvswitch/vport-vxlan.c b/net/openvswitch/vport-vxlan.c
index de9cb19..5eb7694 100644
--- a/net/openvswitch/vport-vxlan.c
+++ b/net/openvswitch/vport-vxlan.c
@@ -90,7 +90,7 @@ static struct vport *vxlan_tnl_create(const struct vport_parms *parms)
int err;
struct vxlan_config conf = {
.no_share = true,
- .flags = VXLAN_F_COLLECT_METADATA,
+ .flags = VXLAN_F_COLLECT_METADATA | VXLAN_F_UDP_ZERO_CSUM6_RX,
/* Don't restrict the packets that can be sent by MTU */
.mtu = IP_MAX_MTU,
};
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6
2016-02-17 18:30 [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6 Paolo Abeni
@ 2016-02-17 19:19 ` Jesse Gross
2016-02-18 9:42 ` Paolo Abeni
2016-02-18 9:53 ` Jiri Benc
2016-02-19 20:40 ` David Miller
2 siblings, 1 reply; 6+ messages in thread
From: Jesse Gross @ 2016-02-17 19:19 UTC (permalink / raw)
To: Paolo Abeni
Cc: Linux Kernel Network Developers, David S. Miller, Thomas Graf,
Jiri Benc, Pravin Shelar, Tom Herbert
On Wed, Feb 17, 2016 at 10:30 AM, Paolo Abeni <pabeni@redhat.com> wrote:
> the commit 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be
> correctly controlled.") changed the default xmit checksum setting
> for lwt vxlan/geneve ipv6 tunnels, so that now the checksum is not
> set into external UDP header.
> This commit changes the rx checksum setting for both lwt vxlan/geneve
> devices created by openvswitch accordingly, so that lwt over ipv6
> tunnel pairs are again able to communicate with default values.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
This is compat code that is being changed here. Based on the previous
discussion, shouldn't these be made the default for all users?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6
2016-02-17 19:19 ` Jesse Gross
@ 2016-02-18 9:42 ` Paolo Abeni
2016-02-18 15:31 ` Jesse Gross
0 siblings, 1 reply; 6+ messages in thread
From: Paolo Abeni @ 2016-02-18 9:42 UTC (permalink / raw)
To: Jesse Gross
Cc: Linux Kernel Network Developers, David S. Miller, Thomas Graf,
Jiri Benc, Pravin Shelar, Tom Herbert
On Wed, 2016-02-17 at 11:19 -0800, Jesse Gross wrote:
> On Wed, Feb 17, 2016 at 10:30 AM, Paolo Abeni <pabeni@redhat.com> wrote:
> > the commit 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be
> > correctly controlled.") changed the default xmit checksum setting
> > for lwt vxlan/geneve ipv6 tunnels, so that now the checksum is not
> > set into external UDP header.
> > This commit changes the rx checksum setting for both lwt vxlan/geneve
> > devices created by openvswitch accordingly, so that lwt over ipv6
> > tunnel pairs are again able to communicate with default values.
> >
> > Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>
> This is compat code that is being changed here. Based on the previous
> discussion, shouldn't these be made the default for all users?
This change was initially aimed at a smaller scope: use self consistent
default for ovs lwt devices/tunnel terminations.
If there is agreement, I can post a separate patch changing the default
rx checksum setting for plain vxlan and geneve[1] devices tunneling over
ipv6.
Paolo
[1] according to the ietf draft the geneve devices have the same
checksum requirement than vxlan ones
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6
2016-02-18 9:42 ` Paolo Abeni
@ 2016-02-18 15:31 ` Jesse Gross
0 siblings, 0 replies; 6+ messages in thread
From: Jesse Gross @ 2016-02-18 15:31 UTC (permalink / raw)
To: Paolo Abeni
Cc: Linux Kernel Network Developers, David S. Miller, Thomas Graf,
Jiri Benc, Pravin Shelar, Tom Herbert
On Thu, Feb 18, 2016 at 1:42 AM, Paolo Abeni <pabeni@redhat.com> wrote:
> On Wed, 2016-02-17 at 11:19 -0800, Jesse Gross wrote:
>> On Wed, Feb 17, 2016 at 10:30 AM, Paolo Abeni <pabeni@redhat.com> wrote:
>> > the commit 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be
>> > correctly controlled.") changed the default xmit checksum setting
>> > for lwt vxlan/geneve ipv6 tunnels, so that now the checksum is not
>> > set into external UDP header.
>> > This commit changes the rx checksum setting for both lwt vxlan/geneve
>> > devices created by openvswitch accordingly, so that lwt over ipv6
>> > tunnel pairs are again able to communicate with default values.
>> >
>> > Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>>
>> This is compat code that is being changed here. Based on the previous
>> discussion, shouldn't these be made the default for all users?
>
> This change was initially aimed at a smaller scope: use self consistent
> default for ovs lwt devices/tunnel terminations.
>
> If there is agreement, I can post a separate patch changing the default
> rx checksum setting for plain vxlan and geneve[1] devices tunneling over
> ipv6.
OK. I think it's important to do the followup to keep things
consistent but this is fine to start.
Acked-by: Jesse Gross <jesse@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6
2016-02-17 18:30 [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6 Paolo Abeni
2016-02-17 19:19 ` Jesse Gross
@ 2016-02-18 9:53 ` Jiri Benc
2016-02-19 20:40 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: Jiri Benc @ 2016-02-18 9:53 UTC (permalink / raw)
To: Paolo Abeni
Cc: netdev, David S. Miller, Jesse Gross, Thomas Graf, Pravin Shelar,
Tom Herbert
On Wed, 17 Feb 2016 19:30:01 +0100, Paolo Abeni wrote:
> the commit 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be
> correctly controlled.") changed the default xmit checksum setting
> for lwt vxlan/geneve ipv6 tunnels, so that now the checksum is not
> set into external UDP header.
> This commit changes the rx checksum setting for both lwt vxlan/geneve
> devices created by openvswitch accordingly, so that lwt over ipv6
> tunnel pairs are again able to communicate with default values.
Acked-by: Jiri Benc <jbenc@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6
2016-02-17 18:30 [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6 Paolo Abeni
2016-02-17 19:19 ` Jesse Gross
2016-02-18 9:53 ` Jiri Benc
@ 2016-02-19 20:40 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-02-19 20:40 UTC (permalink / raw)
To: pabeni; +Cc: netdev, jesse, tgraf, jbenc, pshelar, tom
From: Paolo Abeni <pabeni@redhat.com>
Date: Wed, 17 Feb 2016 19:30:01 +0100
> the commit 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be
> correctly controlled.") changed the default xmit checksum setting
> for lwt vxlan/geneve ipv6 tunnels, so that now the checksum is not
> set into external UDP header.
> This commit changes the rx checksum setting for both lwt vxlan/geneve
> devices created by openvswitch accordingly, so that lwt over ipv6
> tunnel pairs are again able to communicate with default values.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-19 20:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-17 18:30 [PATCH net v2] lwt: fix rx checksum setting for lwt devices tunneling over ipv6 Paolo Abeni
2016-02-17 19:19 ` Jesse Gross
2016-02-18 9:42 ` Paolo Abeni
2016-02-18 15:31 ` Jesse Gross
2016-02-18 9:53 ` Jiri Benc
2016-02-19 20:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).