From: David Miller <davem@davemloft.net>
To: ken_kawasaki@nifty.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] fmvj18x_cs: The MAC address of FMV-J182 is stored at buf[5]
Date: Fri, 19 Feb 2016 22:10:14 -0500 (EST) [thread overview]
Message-ID: <20160219.221014.2230058563470668402.davem@davemloft.net> (raw)
In-Reply-To: <20160220105706.c4da2bbf13902b8bb4df3808@nifty.com>
From: Ken Kawasaki <ken_kawasaki@nifty.com>
Date: Sat, 20 Feb 2016 10:57:06 +0900
>
> The MAC address of FMV-J182 is stored at buf[5].
>
> Signed-off-by: Ken Kawasaki <ken_kawasaki@nifty.com>
This is an extremely poor and misleading description of your change.
The original code was accessing the MAC address properly at buf[5] by
starting the iterator 'i' at 5.
The bug is that the indexing of dev->dev_addr[] is incorrect.
Please describe your change more accurately and resubmit this patch.
Thanks.
next prev parent reply other threads:[~2016-02-20 3:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 1:57 [PATCH] fmvj18x_cs: The MAC address of FMV-J182 is stored at buf[5] Ken Kawasaki
2016-02-20 3:10 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-02-19 12:38 [PATCH]fmvj18x_cs: " Ken Kawasaki
2016-02-19 12:52 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219.221014.2230058563470668402.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ken_kawasaki@nifty.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).