* [PATCH] fmvj18x_cs: The MAC address of FMV-J182 is stored at buf[5]
@ 2016-02-20 1:57 Ken Kawasaki
2016-02-20 3:10 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Ken Kawasaki @ 2016-02-20 1:57 UTC (permalink / raw)
To: netdev
The MAC address of FMV-J182 is stored at buf[5].
Signed-off-by: Ken Kawasaki <ken_kawasaki@nifty.com>
---
--- linux-4.4.1/drivers/net/ethernet/fujitsu/fmvj18x_cs.c.orig 2016-02-19 20:48:40.143852346 +0900
+++ linux-4.4.1/drivers/net/ethernet/fujitsu/fmvj18x_cs.c 2016-02-20 10:33:42.137713831 +0900
@@ -469,8 +469,8 @@ static int fmvj18x_config(struct pcmcia_
goto failed;
}
/* Read MACID from CIS */
- for (i = 5; i < 11; i++)
- dev->dev_addr[i] = buf[i];
+ for (i = 0; i < 6; i++)
+ dev->dev_addr[i] = buf[i + 5];
kfree(buf);
} else {
if (pcmcia_get_mac_from_cis(link, dev))
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fmvj18x_cs: The MAC address of FMV-J182 is stored at buf[5]
2016-02-20 1:57 [PATCH] fmvj18x_cs: The MAC address of FMV-J182 is stored at buf[5] Ken Kawasaki
@ 2016-02-20 3:10 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-02-20 3:10 UTC (permalink / raw)
To: ken_kawasaki; +Cc: netdev
From: Ken Kawasaki <ken_kawasaki@nifty.com>
Date: Sat, 20 Feb 2016 10:57:06 +0900
>
> The MAC address of FMV-J182 is stored at buf[5].
>
> Signed-off-by: Ken Kawasaki <ken_kawasaki@nifty.com>
This is an extremely poor and misleading description of your change.
The original code was accessing the MAC address properly at buf[5] by
starting the iterator 'i' at 5.
The bug is that the indexing of dev->dev_addr[] is incorrect.
Please describe your change more accurately and resubmit this patch.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH]fmvj18x_cs: The MAC address of FMV-J182 is stored at buf[5].
@ 2016-02-19 12:38 Ken Kawasaki
2016-02-19 12:52 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Ken Kawasaki @ 2016-02-19 12:38 UTC (permalink / raw)
To: netdev
The MAC address of FMV-J182 is stored at buf[5].
Signed-off-by: Ken Kawasaki <ken_kawasaki@nifty.com>
---
--- linux-4.4.1/drivers/net/ethernet/fujitsu/fmvj18x_cs.c.orig 2016-02-19 20:48:40.143852346 +0900
+++ linux-4.4.1/drivers/net/ethernet/fujitsu/fmvj18x_cs.c 2016-02-19 20:54:52.345568822 +0900
@@ -469,8 +469,8 @@ static int fmvj18x_config(struct pcmcia_
goto failed;
}
/* Read MACID from CIS */
- for (i = 5; i < 11; i++)
- dev->dev_addr[i] = buf[i];
+ for (i = 0; i < 6; i++)
+ dev->dev_addr[i] = buf[i+5];
kfree(buf);
} else {
if (pcmcia_get_mac_from_cis(link, dev))
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH]fmvj18x_cs: The MAC address of FMV-J182 is stored at buf[5].
2016-02-19 12:38 [PATCH]fmvj18x_cs: " Ken Kawasaki
@ 2016-02-19 12:52 ` Sergei Shtylyov
0 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2016-02-19 12:52 UTC (permalink / raw)
To: Ken Kawasaki, netdev
Hello.
On 2/19/2016 3:38 PM, Ken Kawasaki wrote:
> The MAC address of FMV-J182 is stored at buf[5].
>
> Signed-off-by: Ken Kawasaki <ken_kawasaki@nifty.com>
>
> ---
>
> --- linux-4.4.1/drivers/net/ethernet/fujitsu/fmvj18x_cs.c.orig 2016-02-19 20:48:40.143852346 +0900
> +++ linux-4.4.1/drivers/net/ethernet/fujitsu/fmvj18x_cs.c 2016-02-19 20:54:52.345568822 +0900
> @@ -469,8 +469,8 @@ static int fmvj18x_config(struct pcmcia_
> goto failed;
> }
> /* Read MACID from CIS */
> - for (i = 5; i < 11; i++)
> - dev->dev_addr[i] = buf[i];
> + for (i = 0; i < 6; i++)
> + dev->dev_addr[i] = buf[i+5];
Be consistent please, surround + with spaces.
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-20 3:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-20 1:57 [PATCH] fmvj18x_cs: The MAC address of FMV-J182 is stored at buf[5] Ken Kawasaki
2016-02-20 3:10 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2016-02-19 12:38 [PATCH]fmvj18x_cs: " Ken Kawasaki
2016-02-19 12:52 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).