From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: netdev@vger.kernel.org
Subject: Re: [Patch net-next] phy: marvell/micrel: Fix Unpossible condition
Date: Fri, 19 Feb 2016 23:42:09 -0500 (EST) [thread overview]
Message-ID: <20160219.234209.1817149741397354640.davem@davemloft.net> (raw)
In-Reply-To: <1455924929-12462-1-git-send-email-andrew@lunn.ch>
From: Andrew Lunn <andrew@lunn.ch>
Date: Sat, 20 Feb 2016 00:35:29 +0100
> commit 2b2427d06426 ("phy: micrel: Add ethtool statistics counters")
> from Dec 30, 2015, leads to the following static checker
> warning:
>
> drivers/net/phy/micrel.c:609 kszphy_get_stat()
> warn: unsigned 'val' is never less than zero.
...
> The same problem exists in the Marvell driver. Fix both.
>
> Fixes: 2b2427d06426 ("phy: micrel: Add ethtool statistics counters")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reported-by: Julia.Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks.
prev parent reply other threads:[~2016-02-20 4:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 23:35 [Patch net-next] phy: marvell/micrel: Fix Unpossible condition Andrew Lunn
2016-02-20 4:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219.234209.1817149741397354640.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).