From: David Miller <davem@davemloft.net>
To: jaedon.shin@gmail.com
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com,
pgynther@google.com, opendmb@gmail.com
Subject: Re: [PATCH] net: bcmgenet: Fix internal PHY link state
Date: Fri, 19 Feb 2016 23:52:12 -0500 (EST) [thread overview]
Message-ID: <20160219.235212.2155119722081137261.davem@davemloft.net> (raw)
In-Reply-To: <1455857330-18092-1-git-send-email-jaedon.shin@gmail.com>
From: Jaedon Shin <jaedon.shin@gmail.com>
Date: Fri, 19 Feb 2016 13:48:50 +0900
> The PHY link state is not chaged in GENETv2 caused by the previous
> commit 49f7a471e4d1 ("net: bcmgenet: Properly configure PHY to ignore
> interrupt") was set to PHY_IGNORE_INTERRUPT in bcmgenet_mii_probe().
>
> The internal PHY should use phy_mac_interrupt() when not in use
> PHY_POLL. The statement for phy_mac_interrupt() has two conditions. The
> first condition to check GENET_HAS_MDIO_INTR is not related PHY link
> state, so this patch removes it.
>
> Fixes: 49f7a471e4d1 ("net: bcmgenet: Properly configure PHY to ignore interrupt")
> Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2016-02-20 4:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 4:48 [PATCH] net: bcmgenet: Fix internal PHY link state Jaedon Shin
2016-02-19 5:49 ` Florian Fainelli
2016-02-20 4:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219.235212.2155119722081137261.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jaedon.shin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pgynther@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).