From: Simon Horman <simon.horman@netronome.com>
To: "Amir Vadai\"" <amir@vadai.me>
Cc: John Fastabend <john.fastabend@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
jiri@resnulli.us, davem@davemloft.net, netdev@vger.kernel.org,
jeffrey.t.kirsher@intel.com
Subject: Re: [net-next PATCH v3 3/8] net: sched: add cls_u32 offload hooks for netdevs
Date: Fri, 19 Feb 2016 12:37:15 +0900 [thread overview]
Message-ID: <20160219033712.GA5799@vergenet.net> (raw)
In-Reply-To: <20160218092335.GA15192@office.Home>
On Thu, Feb 18, 2016 at 11:23:35AM +0200, Amir Vadai" wrote:
> On Wed, Feb 17, 2016 at 03:07:23PM -0800, John Fastabend wrote:
> > [...]
> >
> > >>
> > >>> +static void u32_replace_hw_hnode(struct tcf_proto *tp, struct
> > >>> tc_u_hnode *h)
> > >>> +{
> > >>> + struct net_device *dev = tp->q->dev_queue->dev;
> > >>> + struct tc_cls_u32_offload u32_offload = {0};
> > >>> + struct tc_to_netdev offload;
> > >>> +
> > >>> + offload.type = TC_SETUP_CLSU32;
> > >>> + offload.cls_u32 = &u32_offload;
> > >>> +
> > >>> + if (dev->netdev_ops->ndo_setup_tc) {
> > >>> + offload.cls_u32->command = TC_CLSU32_NEW_HNODE;
> > >>
> > >> TC_CLSU32_REPLACE_HNODE?
> > >>
> > >
> > > Yep I made this change and will send out v4.
> > >
> > > [...]
> > >
> > >>
> >
> > Actually thinking about this a bit more I wrote this thinking
> > that there existed some hardware that actually cared if it was
> > a new rule or an existing rule. For me it doesn't matter I do
> > the same thing in the new/replace cases I just write into the
> > slot on the hardware table and if it happens to have something
> > in it well its overwritten e.g. "replaced". This works because
> > the cls_u32 layer protects us from doing something unexpected.
> >
> > I'm wondering (mostly asking the mlx folks) is there hardware
> > out there that cares to make this distinction between new and
> > replace? Otherwise I can just drop new and always use replace.
> > Or vice versa which is the case in its current form.
> I don't see a need for such a distinction in mlx hardware.
FWIW, I think it is unlikely such a distinction would
be needed for Netronome hardware.
next prev parent reply other threads:[~2016-02-19 3:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 5:15 [net-next PATCH v3 0/8] tc offload for cls_u32 on ixgbe John Fastabend
2016-02-17 5:16 ` [net-next PATCH v3 1/8] net: rework ndo tc op to consume additional qdisc handle parameter John Fastabend
2016-02-17 10:42 ` Jamal Hadi Salim
2016-02-17 5:16 ` [net-next PATCH v3 2/8] net: rework setup_tc ndo op to consume general tc operand John Fastabend
2016-02-17 10:42 ` Jamal Hadi Salim
2016-02-17 5:17 ` [net-next PATCH v3 3/8] net: sched: add cls_u32 offload hooks for netdevs John Fastabend
2016-02-17 7:02 ` Jiri Pirko
2016-02-17 10:59 ` Jamal Hadi Salim
2016-02-17 14:24 ` John Fastabend
2016-02-17 23:07 ` John Fastabend
2016-02-18 9:23 ` Amir Vadai"
2016-02-19 3:37 ` Simon Horman [this message]
2016-02-19 8:16 ` Or Gerlitz
2016-02-18 12:14 ` Jamal Hadi Salim
2016-02-18 15:24 ` John Fastabend
2016-02-19 12:52 ` Jamal Hadi Salim
2016-02-17 5:17 ` [net-next PATCH v3 4/8] net: add tc offload feature flag John Fastabend
2016-02-17 11:01 ` Jamal Hadi Salim
2016-02-17 5:18 ` [net-next PATCH v3 5/8] net: tc: helper functions to query action types John Fastabend
2016-02-17 7:03 ` Jiri Pirko
2016-02-17 11:02 ` Jamal Hadi Salim
2016-02-17 5:18 ` [net-next PATCH v3 6/8] net: ixgbe: add minimal parser details for ixgbe John Fastabend
2016-02-17 11:06 ` Jamal Hadi Salim
2016-02-17 15:09 ` David Miller
2016-02-17 15:14 ` John Fastabend
2016-02-17 18:01 ` Rustad, Mark D
2016-02-17 22:34 ` John Fastabend
2016-02-17 5:18 ` [net-next PATCH v3 7/8] net: ixgbe: add support for tc_u32 offload John Fastabend
2016-02-17 11:17 ` Jamal Hadi Salim
2016-02-17 11:42 ` Jiri Pirko
2016-02-17 11:47 ` Jamal Hadi Salim
2016-02-17 14:25 ` John Fastabend
2016-02-17 5:19 ` [net-next PATCH v3 8/8] net: ixgbe: abort with cls u32 divisor groups greater than 1 John Fastabend
2016-02-17 14:48 ` [net-next PATCH v3 0/8] tc offload for cls_u32 on ixgbe David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219033712.GA5799@vergenet.net \
--to=simon.horman@netronome.com \
--cc=amir@vadai.me \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).