From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Subject: Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO Date: Fri, 19 Feb 2016 13:59:09 +0530 Message-ID: <20160219082909.GA6312@sudip-pc> References: <1455372195-10825-1-git-send-email-sudipm.mukherjee@gmail.com> <20160216.203606.1431228679408727525.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: f.fainelli@gmail.com, linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, netdev@vger.kernel.org, geert@linux-m68k.org, helmut.buchsbaum@gmail.com To: David Miller Return-path: Content-Disposition: inline In-Reply-To: <20160216.203606.1431228679408727525.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, Feb 16, 2016 at 08:36:06PM -0500, David Miller wrote: > From: Sudip Mukherjee > Date: Sat, 13 Feb 2016 19:33:15 +0530 > > > The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing > > with the error: > > drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' > > drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc' > > > > GPIO is now used to reset the switch so we should have a dependency on > > GPIOLIB. While adding the dependency also add COMPILE_TEST so that we > > can build test it. > > > > Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO") > > Cc: Helmut Buchsbaum > > Signed-off-by: Sudip Mukherjee > > --- > > > > v2: added COMPILE_TEST and gpio/consumer.h > > I'm going to apply Arnd's patch because it properly removes the > unnecessary linux/gpio.h include. I think Arnd's patch is still not applied as we are still having build failures for the implicit declarations. Or you want me to send v3 after removing unnecessary linux/gpio.h include? regards suduo