From: Thadeu Lima de Souza Cascardo <cascardo@debian.org>
To: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Cc: cascardo@linux.vnet.ibm.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, julia.lawall@lip6.fr
Subject: Re: [PATCH] ehea: Drop owner assignment from platform_driver
Date: Fri, 19 Feb 2016 09:35:25 -0200 [thread overview]
Message-ID: <20160219113524.GR4148@siri.cascardo.eti.br> (raw)
In-Reply-To: <20160219112219.GA2366@amitoj-Inspiron-3542>
On Fri, Feb 19, 2016 at 04:52:19PM +0530, Amitoj Kaur Chawla wrote:
> platform_driver does not need to set an owner, it will be populated by
> the driver core.
>
> Generated-by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> index 2a0dc12..d4b022f 100644
> --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> @@ -127,7 +127,6 @@ static const struct of_device_id ehea_device_table[] = {
> static struct platform_driver ehea_driver = {
> .driver = {
> .name = "ehea",
> - .owner = THIS_MODULE,
> .of_match_table = ehea_device_table,
> },
> .probe = ehea_probe_adapter,
> --
> 1.9.1
>
NACK.
ehea does not use platform_driver_register, it uses
ibmebus_register_driver, which does not set owner.
Cascardo.
next prev parent reply other threads:[~2016-02-19 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 11:22 [PATCH] ehea: Drop owner assignment from platform_driver Amitoj Kaur Chawla
2016-02-19 11:35 ` Thadeu Lima de Souza Cascardo [this message]
2016-02-19 12:06 ` Julia Lawall
2016-02-19 12:15 ` Thadeu Lima de Souza Cascardo
2016-02-19 13:07 ` Amitoj Kaur Chawla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219113524.GR4148@siri.cascardo.eti.br \
--to=cascardo@debian.org \
--cc=amitoj1606@gmail.com \
--cc=cascardo@linux.vnet.ibm.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).