* [PATCH] ehea: Drop owner assignment from platform_driver
@ 2016-02-19 11:22 Amitoj Kaur Chawla
2016-02-19 11:35 ` Thadeu Lima de Souza Cascardo
0 siblings, 1 reply; 5+ messages in thread
From: Amitoj Kaur Chawla @ 2016-02-19 11:22 UTC (permalink / raw)
To: cascardo, netdev, linux-kernel; +Cc: julia.lawall
platform_driver does not need to set an owner, it will be populated by
the driver core.
Generated-by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
index 2a0dc12..d4b022f 100644
--- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
+++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
@@ -127,7 +127,6 @@ static const struct of_device_id ehea_device_table[] = {
static struct platform_driver ehea_driver = {
.driver = {
.name = "ehea",
- .owner = THIS_MODULE,
.of_match_table = ehea_device_table,
},
.probe = ehea_probe_adapter,
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ehea: Drop owner assignment from platform_driver
2016-02-19 11:22 [PATCH] ehea: Drop owner assignment from platform_driver Amitoj Kaur Chawla
@ 2016-02-19 11:35 ` Thadeu Lima de Souza Cascardo
2016-02-19 12:06 ` Julia Lawall
2016-02-19 13:07 ` Amitoj Kaur Chawla
0 siblings, 2 replies; 5+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2016-02-19 11:35 UTC (permalink / raw)
To: Amitoj Kaur Chawla; +Cc: cascardo, netdev, linux-kernel, julia.lawall
On Fri, Feb 19, 2016 at 04:52:19PM +0530, Amitoj Kaur Chawla wrote:
> platform_driver does not need to set an owner, it will be populated by
> the driver core.
>
> Generated-by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> index 2a0dc12..d4b022f 100644
> --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> @@ -127,7 +127,6 @@ static const struct of_device_id ehea_device_table[] = {
> static struct platform_driver ehea_driver = {
> .driver = {
> .name = "ehea",
> - .owner = THIS_MODULE,
> .of_match_table = ehea_device_table,
> },
> .probe = ehea_probe_adapter,
> --
> 1.9.1
>
NACK.
ehea does not use platform_driver_register, it uses
ibmebus_register_driver, which does not set owner.
Cascardo.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ehea: Drop owner assignment from platform_driver
2016-02-19 11:35 ` Thadeu Lima de Souza Cascardo
@ 2016-02-19 12:06 ` Julia Lawall
2016-02-19 12:15 ` Thadeu Lima de Souza Cascardo
2016-02-19 13:07 ` Amitoj Kaur Chawla
1 sibling, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2016-02-19 12:06 UTC (permalink / raw)
To: Thadeu Lima de Souza Cascardo
Cc: Amitoj Kaur Chawla, cascardo, netdev, linux-kernel
On Fri, 19 Feb 2016, Thadeu Lima de Souza Cascardo wrote:
> On Fri, Feb 19, 2016 at 04:52:19PM +0530, Amitoj Kaur Chawla wrote:
> > platform_driver does not need to set an owner, it will be populated by
> > the driver core.
> >
> > Generated-by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> >
> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> > ---
> > drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > index 2a0dc12..d4b022f 100644
> > --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > @@ -127,7 +127,6 @@ static const struct of_device_id ehea_device_table[] = {
> > static struct platform_driver ehea_driver = {
> > .driver = {
> > .name = "ehea",
> > - .owner = THIS_MODULE,
> > .of_match_table = ehea_device_table,
> > },
> > .probe = ehea_probe_adapter,
> > --
> > 1.9.1
> >
>
> NACK.
>
> ehea does not use platform_driver_register, it uses
> ibmebus_register_driver, which does not set owner.
Thanks for the information. I will try to update the saemantic patch.
julia
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ehea: Drop owner assignment from platform_driver
2016-02-19 12:06 ` Julia Lawall
@ 2016-02-19 12:15 ` Thadeu Lima de Souza Cascardo
0 siblings, 0 replies; 5+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2016-02-19 12:15 UTC (permalink / raw)
To: Julia Lawall; +Cc: Amitoj Kaur Chawla, cascardo, netdev, linux-kernel
On Fri, Feb 19, 2016 at 07:06:46AM -0500, Julia Lawall wrote:
> On Fri, 19 Feb 2016, Thadeu Lima de Souza Cascardo wrote:
> > On Fri, Feb 19, 2016 at 04:52:19PM +0530, Amitoj Kaur Chawla wrote:
> > > platform_driver does not need to set an owner, it will be populated by
> > > the driver core.
> > >
> > > Generated-by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> > >
> > > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> > > ---
> > > drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > > index 2a0dc12..d4b022f 100644
> > > --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > > +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> > > @@ -127,7 +127,6 @@ static const struct of_device_id ehea_device_table[] = {
> > > static struct platform_driver ehea_driver = {
> > > .driver = {
> > > .name = "ehea",
> > > - .owner = THIS_MODULE,
> > > .of_match_table = ehea_device_table,
> > > },
> > > .probe = ehea_probe_adapter,
> > > --
> > > 1.9.1
> > >
> >
> > NACK.
> >
> > ehea does not use platform_driver_register, it uses
> > ibmebus_register_driver, which does not set owner.
>
> Thanks for the information. I will try to update the saemantic patch.
>
> julia
Thanks, Julia. I appreciate your work on that.
Cascardo.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ehea: Drop owner assignment from platform_driver
2016-02-19 11:35 ` Thadeu Lima de Souza Cascardo
2016-02-19 12:06 ` Julia Lawall
@ 2016-02-19 13:07 ` Amitoj Kaur Chawla
1 sibling, 0 replies; 5+ messages in thread
From: Amitoj Kaur Chawla @ 2016-02-19 13:07 UTC (permalink / raw)
To: Thadeu Lima de Souza Cascardo
Cc: cascardo, netdev, Linux-Kernel@Vger. Kernel. Org, Julia Lawall
On Fri, Feb 19, 2016 at 5:05 PM, Thadeu Lima de Souza Cascardo
<cascardo@debian.org> wrote:
> NACK.
>
> ehea does not use platform_driver_register, it uses
> ibmebus_register_driver, which does not set owner.
>
> Cascardo.
Thanks for the feedback. I'll make sure to check for this in the future.
Amitoj
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-19 13:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-19 11:22 [PATCH] ehea: Drop owner assignment from platform_driver Amitoj Kaur Chawla
2016-02-19 11:35 ` Thadeu Lima de Souza Cascardo
2016-02-19 12:06 ` Julia Lawall
2016-02-19 12:15 ` Thadeu Lima de Souza Cascardo
2016-02-19 13:07 ` Amitoj Kaur Chawla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).