From: David Miller <davem@davemloft.net>
To: mahesh@bandewar.net
Cc: maheshb@google.com, edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH next v4 0/3] IPvlan misc patches
Date: Sun, 21 Feb 2016 22:45:16 -0500 (EST) [thread overview]
Message-ID: <20160221.224516.345929630999490010.davem@davemloft.net> (raw)
In-Reply-To: <1456025482-30203-1-git-send-email-mahesh@bandewar.net>
From: Mahesh Bandewar <mahesh@bandewar.net>
Date: Sat, 20 Feb 2016 19:31:22 -0800
> From: Mahesh Bandewar <maheshb@google.com>
>
> This is a collection of unrelated patches for IPvlan driver.
> a. crub_skb() changes are added to ensure that the packets hit the
> NF_HOOKS in masters' ns in L3 mode.
> b. u16 change is bug fix while
> c. the third patch is to group tx/rx variables in single cacheline
I applied this series, but this is an extremely poor quality
submission.
You don't capitalize sentences, particularly in the Subject lines
of your patches.
Your descriptions are quite poor. You say here that patch 'c' is
about grouping things for cache locality but that patch does a lot
of completely unrelated things too.
I really think you put very little effort into the formatting,
descriptions, grouping, and general layout of this patch series. And
it shows.
prev parent reply other threads:[~2016-02-22 3:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 3:31 [PATCH next v4 0/3] IPvlan misc patches Mahesh Bandewar
2016-02-22 3:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160221.224516.345929630999490010.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=mahesh@bandewar.net \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).