* [PATCH next v4 0/3] IPvlan misc patches
@ 2016-02-21 3:31 Mahesh Bandewar
2016-02-22 3:45 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mahesh Bandewar @ 2016-02-21 3:31 UTC (permalink / raw)
To: David Miller; +Cc: Mahesh Bandewar, Eric Dumazet, netdev
From: Mahesh Bandewar <maheshb@google.com>
This is a collection of unrelated patches for IPvlan driver.
a. crub_skb() changes are added to ensure that the packets hit the
NF_HOOKS in masters' ns in L3 mode.
b. u16 change is bug fix while
c. the third patch is to group tx/rx variables in single cacheline
Mahesh Bandewar (3):
ipvlan: scrub skb before routing in L3 mode.
ipvlan: mode is u16
ipvlan: misc changes
drivers/net/ipvlan/ipvlan.h | 10 +++------
drivers/net/ipvlan/ipvlan_core.c | 46 +++++++++++++++++++++++-----------------
drivers/net/ipvlan/ipvlan_main.c | 11 ++++++----
3 files changed, 36 insertions(+), 31 deletions(-)
--
2.7.0.rc3.207.g0ac5344
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH next v4 0/3] IPvlan misc patches
2016-02-21 3:31 [PATCH next v4 0/3] IPvlan misc patches Mahesh Bandewar
@ 2016-02-22 3:45 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-02-22 3:45 UTC (permalink / raw)
To: mahesh; +Cc: maheshb, edumazet, netdev
From: Mahesh Bandewar <mahesh@bandewar.net>
Date: Sat, 20 Feb 2016 19:31:22 -0800
> From: Mahesh Bandewar <maheshb@google.com>
>
> This is a collection of unrelated patches for IPvlan driver.
> a. crub_skb() changes are added to ensure that the packets hit the
> NF_HOOKS in masters' ns in L3 mode.
> b. u16 change is bug fix while
> c. the third patch is to group tx/rx variables in single cacheline
I applied this series, but this is an extremely poor quality
submission.
You don't capitalize sentences, particularly in the Subject lines
of your patches.
Your descriptions are quite poor. You say here that patch 'c' is
about grouping things for cache locality but that patch does a lot
of completely unrelated things too.
I really think you put very little effort into the formatting,
descriptions, grouping, and general layout of this patch series. And
it shows.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-22 3:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-21 3:31 [PATCH next v4 0/3] IPvlan misc patches Mahesh Bandewar
2016-02-22 3:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).