From: David Miller <davem@davemloft.net>
To: sudipm.mukherjee@gmail.com
Cc: w-kwok2@ti.com, m-karicheri2@ti.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
john.r.fastabend@intel.com
Subject: Re: [PATCH] netcp: use pointer to fix build fail
Date: Mon, 22 Feb 2016 12:46:51 -0500 (EST) [thread overview]
Message-ID: <20160222.124651.135368011882918651.davem@davemloft.net> (raw)
In-Reply-To: <1456161943-9206-1-git-send-email-sudipm.mukherjee@gmail.com>
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: Mon, 22 Feb 2016 22:55:43 +0530
> While building keystone_defconfig of arm we are getting build failure
> with the error:
...
> The callback of ndo_setup_tc should be:
> int (*ndo_setup_tc)(struct net_device *dev, u32 handle, __be16 protocol,
> struct tc_to_netdev *tc);
>
> But we missed marking the last argument as a pointer.
>
> Fixes: 16e5cc647173 ("net: rework setup_tc ndo op to consume general tc operand")
> CC: John Fastabend <john.r.fastabend@intel.com>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Applied, thanks.
prev parent reply other threads:[~2016-02-22 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 17:25 [PATCH] netcp: use pointer to fix build fail Sudip Mukherjee
2016-02-22 17:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222.124651.135368011882918651.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=john.r.fastabend@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=w-kwok2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).