Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

Jiri Pirko
2016-02-23T15:30:26Z

Tue, Feb 23, 2016 at 04:16:11PM CET, hannes@stressinduktion.org wrote:

<snip>

>>>1) is easily solvable, just drop the ifindex style attributes and always
>>>force the user to enter the bus and bus-topology id.
>>
>>But why? Use can easily get that info and map it to devlink index. It
>>aligns with nl80211 iface.
>>
>>Do you really want to do commands like:
>>myhost:~$ dl dev show pci_0000:01:00.0
>> ?
>
>Yes, exactly I would. I would put them into a boot-up script based on my
>system configuration and can be sure it will work the next boot, too, and
>adapt them when I replace the hardware or do some configuration changes.
>
>I think sysadmins or scripts are the primary users of this interface not
>kernel developers which switch their settings around all the time, no?

I can easily add this to the userspace tool to accept "pci_0000:01:00.0"
format and to map it internally to devlink index. No problem.