* [patch] rocker: fix rocker_world_port_obj_vlan_add()
@ 2016-02-23 9:37 Dan Carpenter
2016-02-23 9:39 ` Jiri Pirko
2016-02-23 18:12 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-02-23 9:37 UTC (permalink / raw)
To: Jiri Pirko; +Cc: Scott Feldman, netdev, kernel-janitors
We were changing return values and accidentally made
rocker_world_port_obj_vlan_add() into a no-op.
Fixes: fccd84d44912 ('rocker: return -EOPNOTSUPP for undefined world ops')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c
index acafbf8..28b775e 100644
--- a/drivers/net/ethernet/rocker/rocker_main.c
+++ b/drivers/net/ethernet/rocker/rocker_main.c
@@ -1598,7 +1598,6 @@ rocker_world_port_obj_vlan_add(struct rocker_port *rocker_port,
if (!wops->port_obj_vlan_add)
return -EOPNOTSUPP;
- return 0;
return wops->port_obj_vlan_add(rocker_port, vlan, trans);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] rocker: fix rocker_world_port_obj_vlan_add()
2016-02-23 9:37 [patch] rocker: fix rocker_world_port_obj_vlan_add() Dan Carpenter
@ 2016-02-23 9:39 ` Jiri Pirko
2016-02-23 18:12 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2016-02-23 9:39 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Scott Feldman, netdev, kernel-janitors
Tue, Feb 23, 2016 at 10:37:52AM CET, dan.carpenter@oracle.com wrote:
>We were changing return values and accidentally made
>rocker_world_port_obj_vlan_add() into a no-op.
>
>Fixes: fccd84d44912 ('rocker: return -EOPNOTSUPP for undefined world ops')
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Oops. Thanks for the fix.
Acked-by: Jiri Pirko <jiri@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] rocker: fix rocker_world_port_obj_vlan_add()
2016-02-23 9:37 [patch] rocker: fix rocker_world_port_obj_vlan_add() Dan Carpenter
2016-02-23 9:39 ` Jiri Pirko
@ 2016-02-23 18:12 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-02-23 18:12 UTC (permalink / raw)
To: dan.carpenter; +Cc: jiri, sfeldma, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 23 Feb 2016 12:37:52 +0300
> We were changing return values and accidentally made
> rocker_world_port_obj_vlan_add() into a no-op.
>
> Fixes: fccd84d44912 ('rocker: return -EOPNOTSUPP for undefined world ops')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-23 18:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-23 9:37 [patch] rocker: fix rocker_world_port_obj_vlan_add() Dan Carpenter
2016-02-23 9:39 ` Jiri Pirko
2016-02-23 18:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).