From: David Miller <davem@davemloft.net>
To: saeedm@dev.mellanox.co.il
Cc: saeedm@mellanox.com, netdev@vger.kernel.org, galp@mellanox.com,
ogerlitz@mellanox.com, kaber@trash.net
Subject: Re: [PATCH net] net/8021q: Check the correct vlan filter capability
Date: Wed, 24 Feb 2016 16:49:34 -0500 (EST) [thread overview]
Message-ID: <20160224.164934.1286780116750770665.davem@davemloft.net> (raw)
In-Reply-To: <CALzJLG8CiRRBqUziAFOXE2RAmEDUMgJK2GM6SF3mz_HueRfdvQ@mail.gmail.com>
From: Saeed Mahameed <saeedm@dev.mellanox.co.il>
Date: Wed, 24 Feb 2016 22:35:16 +0200
> BTW we choose the first option since the "buggy" function is called
> "vlan_hw_filter_capable" which lead us to decide that the function
> should be looking for ->hw_features and not ->features.
> and i think this way it makes more sense.
Again, anything doing checks on ->hw_features other than for the
purposes of the validation of a ->feature change is a bug.
next prev parent reply other threads:[~2016-02-24 21:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 16:39 [PATCH net] net/8021q: Check the correct vlan filter capability Saeed Mahameed
2016-02-24 16:48 ` David Miller
2016-02-24 20:27 ` Saeed Mahameed
2016-02-24 20:35 ` Saeed Mahameed
2016-02-24 21:49 ` David Miller [this message]
2016-02-24 21:48 ` David Miller
2016-02-25 3:58 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224.164934.1286780116750770665.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=galp@mellanox.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=saeedm@dev.mellanox.co.il \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).