From: David Miller <davem@davemloft.net>
To: g.nault@alphalink.fr
Cc: netdev@vger.kernel.org, paulus@samba.org
Subject: Re: [PATCH net-next] ppp: clarify parsing of user supplied data in ppp_set_compress()
Date: Wed, 24 Feb 2016 23:53:15 -0500 (EST) [thread overview]
Message-ID: <20160224.235315.1205744186191236308.davem@davemloft.net> (raw)
In-Reply-To: <4765fab0f32c4a2391828b8c418592f4a5bcede6.1456232225.git.g.nault@alphalink.fr>
From: Guillaume Nault <g.nault@alphalink.fr>
Date: Tue, 23 Feb 2016 13:59:43 +0100
> * Split big conditional statement.
> * Check (data.length <= CCP_MAX_OPTION_LENGTH) only once.
> * Don't read ccp_option[1] if not initialised.
>
> Reading uninitialised ccp_option[1] was harmless, because this could
> only happen when data.length was 0 or 1. So even then, we couldn't pass
> the (ccp_option[1] < 2 || ccp_option[1] > data.length) test anyway.
>
> Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Applied, thanks.
prev parent reply other threads:[~2016-02-25 4:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 12:59 [PATCH net-next] ppp: clarify parsing of user supplied data in ppp_set_compress() Guillaume Nault
2016-02-25 4:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224.235315.1205744186191236308.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=g.nault@alphalink.fr \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).