netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: michael.chan@broadcom.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 01/10] bnxt_en: Improve bnxt_vf_update_mac().
Date: Thu, 25 Feb 2016 11:31:28 -0500 (EST)	[thread overview]
Message-ID: <20160225.113128.1989544272292631983.davem@davemloft.net> (raw)
In-Reply-To: <1456388374-1440-2-git-send-email-michael.chan@broadcom.com>

From: Michael Chan <michael.chan@broadcom.com>
Date: Thu, 25 Feb 2016 03:19:25 -0500

> From: Jeffrey Huang <huangjw@broadcom.com>
> 
> Allow the VF to setup its own MAC address if the PF has not administratively
> set it for the VF.  If the perm_mac_address returned by firmware is all
> zeros, that means the PF has not set up the MAC address for the VF and
> we should store it.  This will allow the VF to change the MAC address using
> ndo_set_mac_address() when it sees that the stored permanent MAC address
> is all zeros.
> 
> Signed-off-by: Jeffrey Huang <huangjw@broadcom.com>
> Signed-off-by: Michael Chan <michael.chan@broadcom.com>

What triggers that ->ndo_set_mac_address() call in the VF?

You cannot register an ethernet netdev with an invalid ethernet address,
you must use a random one if you don't have a valid one available.

  reply	other threads:[~2016-02-25 16:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25  8:19 [PATCH net-next 00/10] bnxt_en: updates for net-next Michael Chan
2016-02-25  8:19 ` [PATCH net-next 01/10] bnxt_en: Improve bnxt_vf_update_mac() Michael Chan
2016-02-25 16:31   ` David Miller [this message]
2016-02-25 16:57     ` Michael Chan
2016-02-25 17:09       ` David Miller
2016-02-25 17:15         ` Michael Chan
2016-02-25 19:02           ` David Miller
2016-02-25  8:19 ` [PATCH net-next 02/10] bnxt_en: Send PF driver unload notification to all VFs Michael Chan
2016-02-25  8:19 ` [PATCH net-next 03/10] bnxt_en: Store irq coalescing timer values in micro seconds Michael Chan
2016-02-25  8:19 ` [PATCH net-next 04/10] bnxt_en: Refactor bnxt_hwrm_set_coal() Michael Chan
2016-02-25 16:32   ` David Miller
2016-02-25  8:19 ` [PATCH net-next 05/10] bnxt_en: Add coalescing support for tx rings Michael Chan
2016-02-25  8:19 ` [PATCH net-next 06/10] bnxt_en: Use firmware provided message timeout value Michael Chan
2016-02-25  8:19 ` [PATCH net-next 07/10] bnxt_en: Fix dmesg log firmware error messages Michael Chan
2016-02-25  8:19 ` [PATCH net-next 08/10] bnxt_en: Add installed-package firmware version reporting via Ethtool GDRVINFO Michael Chan
2016-02-25  8:19 ` [PATCH net-next 09/10] bnxt_en: Refactor _hwrm_send_message() Michael Chan
2016-02-25  8:19 ` [PATCH net-next 10/10] bnxt_en: Add hwrm_send_message_silent() Michael Chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160225.113128.1989544272292631983.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).