* [PATCH 1/2] net: qca_spi: Don't clear IFF_BROADCAST
@ 2016-02-23 19:23 Stefan Wahren
2016-02-23 19:23 ` [PATCH 2/2] net: qca_spi: clear IFF_TX_SKB_SHARING Stefan Wahren
2016-02-25 21:14 ` [PATCH 1/2] net: qca_spi: Don't clear IFF_BROADCAST David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Wahren @ 2016-02-23 19:23 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, linux-kernel, Stefan Wahren
Currently qcaspi_netdev_setup accidentally clears IFF_BROADCAST.
So fix this by keeping the flags from ether_setup.
Reported-by: Michael Heimpold <michael.heimpold@i2se.com>
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Fixes: 291ab06ecf67 (net: qualcomm: new Ethernet over SPI driver for QCA7000)
---
drivers/net/ethernet/qualcomm/qca_spi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c
index 689a4a5..f2ee3e5f 100644
--- a/drivers/net/ethernet/qualcomm/qca_spi.c
+++ b/drivers/net/ethernet/qualcomm/qca_spi.c
@@ -811,7 +811,6 @@ qcaspi_netdev_setup(struct net_device *dev)
dev->netdev_ops = &qcaspi_netdev_ops;
qcaspi_set_ethtool_ops(dev);
dev->watchdog_timeo = QCASPI_TX_TIMEOUT;
- dev->flags = IFF_MULTICAST;
dev->tx_queue_len = 100;
qca = netdev_priv(dev);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] net: qca_spi: clear IFF_TX_SKB_SHARING
2016-02-23 19:23 [PATCH 1/2] net: qca_spi: Don't clear IFF_BROADCAST Stefan Wahren
@ 2016-02-23 19:23 ` Stefan Wahren
2016-02-25 21:14 ` David Miller
2016-02-25 21:14 ` [PATCH 1/2] net: qca_spi: Don't clear IFF_BROADCAST David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Wahren @ 2016-02-23 19:23 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, linux-kernel, Stefan Wahren
ether_setup sets IFF_TX_SKB_SHARING but this is not supported by
qca_spi as it modifies the skb on xmit.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Fixes: 291ab06ecf67 (net: qualcomm: new Ethernet over SPI driver for QCA7000)
---
drivers/net/ethernet/qualcomm/qca_spi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c
index f2ee3e5f..1ef0393 100644
--- a/drivers/net/ethernet/qualcomm/qca_spi.c
+++ b/drivers/net/ethernet/qualcomm/qca_spi.c
@@ -811,6 +811,7 @@ qcaspi_netdev_setup(struct net_device *dev)
dev->netdev_ops = &qcaspi_netdev_ops;
qcaspi_set_ethtool_ops(dev);
dev->watchdog_timeo = QCASPI_TX_TIMEOUT;
+ dev->priv_flags &= ~IFF_TX_SKB_SHARING;
dev->tx_queue_len = 100;
qca = netdev_priv(dev);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] net: qca_spi: Don't clear IFF_BROADCAST
2016-02-23 19:23 [PATCH 1/2] net: qca_spi: Don't clear IFF_BROADCAST Stefan Wahren
2016-02-23 19:23 ` [PATCH 2/2] net: qca_spi: clear IFF_TX_SKB_SHARING Stefan Wahren
@ 2016-02-25 21:14 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2016-02-25 21:14 UTC (permalink / raw)
To: stefan.wahren; +Cc: netdev, linux-kernel
From: Stefan Wahren <stefan.wahren@i2se.com>
Date: Tue, 23 Feb 2016 19:23:23 +0000
> Currently qcaspi_netdev_setup accidentally clears IFF_BROADCAST.
> So fix this by keeping the flags from ether_setup.
>
> Reported-by: Michael Heimpold <michael.heimpold@i2se.com>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Fixes: 291ab06ecf67 (net: qualcomm: new Ethernet over SPI driver for QCA7000)
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] net: qca_spi: clear IFF_TX_SKB_SHARING
2016-02-23 19:23 ` [PATCH 2/2] net: qca_spi: clear IFF_TX_SKB_SHARING Stefan Wahren
@ 2016-02-25 21:14 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-02-25 21:14 UTC (permalink / raw)
To: stefan.wahren; +Cc: netdev, linux-kernel
From: Stefan Wahren <stefan.wahren@i2se.com>
Date: Tue, 23 Feb 2016 19:23:24 +0000
> ether_setup sets IFF_TX_SKB_SHARING but this is not supported by
> qca_spi as it modifies the skb on xmit.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Fixes: 291ab06ecf67 (net: qualcomm: new Ethernet over SPI driver for QCA7000)
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-25 21:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-23 19:23 [PATCH 1/2] net: qca_spi: Don't clear IFF_BROADCAST Stefan Wahren
2016-02-23 19:23 ` [PATCH 2/2] net: qca_spi: clear IFF_TX_SKB_SHARING Stefan Wahren
2016-02-25 21:14 ` David Miller
2016-02-25 21:14 ` [PATCH 1/2] net: qca_spi: Don't clear IFF_BROADCAST David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).