From: David Miller <davem@davemloft.net>
To: f6bvp@free.fr
Cc: netdev@vger.kernel.org, ralf@linux-mips.org
Subject: Re: [Patch] rose_route_frame() NULL pointer dereference kernel panic
Date: Thu, 25 Feb 2016 17:09:57 -0500 (EST) [thread overview]
Message-ID: <20160225.170957.836114237953219422.davem@davemloft.net> (raw)
In-Reply-To: <56CDDFF7.2040609@free.fr>
From: f6bvp <f6bvp@free.fr>
Date: Wed, 24 Feb 2016 17:53:11 +0100
> @@ -863,6 +863,11 @@ int rose_route_frame(struct sk_buff *skb, ax25_cb
> *ax25)
First of all this patch was corrupted by your email client.
> int res = 0;
> char buf[11];
>
> + if (ax25 == NULL) {
> + printk("Null ax25 destination !\n");
> + return res;
> + }
Second of all, this log message is not appropriate, especially given that
rose_xmit() calls rose_rout_frame() with an explicit NULL second argument.
next prev parent reply other threads:[~2016-02-25 22:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 16:53 [Patch] rose_route_frame() NULL pointer dereference kernel panic f6bvp
2016-02-25 22:09 ` David Miller [this message]
2016-03-01 20:37 ` f6bvp
2016-03-03 22:02 ` David Miller
2016-03-05 15:32 ` f6bvp
2016-03-05 16:22 ` David Miller
2016-03-05 17:32 ` f6bvp
2016-03-05 19:57 ` Francois Romieu
[not found] ` <56DC0B8A.5030708@free.fr>
2016-03-06 10:58 ` f6bvp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225.170957.836114237953219422.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f6bvp@free.fr \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).