From: Jiri Benc <jbenc@redhat.com>
To: Jesse Gross <jesse@kernel.org>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 5/5] vxlan: implement GPE in L3 mode
Date: Sat, 27 Feb 2016 20:21:59 +0100 [thread overview]
Message-ID: <20160227202159.6507b8b9@griffin> (raw)
In-Reply-To: <CAEh+42hC=Bx3FFGH=Eij-HGNN5jgZh_PmBbzp_3YPnWKpyTn1w@mail.gmail.com>
On Fri, 26 Feb 2016 14:22:03 -0800, Jesse Gross wrote:
> Given that VXLAN_GPE_MODE_L3 will eventually come to be used by NSH,
> MPLS, etc. in addition to IPv4/v6, most of which are not really L3, it
> seems like something along the lines of NO_ARP might be better since
> that's what it really indicates.
I have no problem naming this differently. Not sure NO_ARP is the best
name, though - this is more about absence of the L2 header in received
packets than about ARP.
> Once that is in, I don't really see
> the need to explicitly block Ethernet packets from being handled in
> this mode. If they are received, then they can just be handed off to
> the stack - at that point it would look like an extra header, the same
> as if an NSH packet is received.
You mean returning ETH_P_TEB in skb->protocol? That's not much useful,
unfortunately. You won't get such packet processed by the kernel IP
stack, rendering the VXLAN-GPE device unusable outside of ovs. It would
effectively became a packet sink when used standalone, as it cannot be
added to bridge and received packets are not processed by anything -
there's no protocol handler for ETH_P_TEB.
With this patchset, you can create a VXLAN-GPE interface and use it as
any other point to point interface, and it works as expected with
routing etc.
The distinction between Ethernet and no Ethernet is needed, the
interface won't work otherwise.
Jiri
next prev parent reply other threads:[~2016-02-27 19:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 7:48 [PATCH net-next 0/5] vxlan: implement Generic Protocol Extension (GPE) Jiri Benc
2016-02-26 7:48 ` [PATCH net-next 1/5] vxlan: implement GPE in L2 mode Jiri Benc
2016-02-26 23:51 ` Tom Herbert
2016-02-27 19:31 ` Jiri Benc
2016-02-27 20:54 ` Tom Herbert
2016-02-27 21:02 ` Tom Herbert
2016-02-29 10:23 ` Jiri Benc
2016-02-29 17:13 ` Tom Herbert
2016-03-01 18:16 ` Jiri Benc
2016-02-26 7:48 ` [PATCH net-next 2/5] vxlan: move L2 mode initialization to a separate function Jiri Benc
2016-02-26 7:48 ` [PATCH net-next 3/5] vxlan: move fdb code to common location in vxlan_xmit Jiri Benc
2016-02-26 7:48 ` [PATCH net-next 4/5] vxlan: fix too large pskb_may_pull with remote checksum Jiri Benc
2016-02-26 7:48 ` [PATCH net-next 5/5] vxlan: implement GPE in L3 mode Jiri Benc
2016-02-26 22:22 ` Jesse Gross
2016-02-26 23:42 ` Tom Herbert
2016-02-27 19:26 ` Jiri Benc
2016-02-27 19:21 ` Jiri Benc [this message]
2016-02-27 19:44 ` Jiri Benc
2016-03-08 22:18 ` Jesse Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160227202159.6507b8b9@griffin \
--to=jbenc@redhat.com \
--cc=jesse@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).