From: David Miller <davem@davemloft.net>
To: ben@decadent.org.uk
Cc: sixiao@microsoft.com, kys@microsoft.com, haiyangz@microsoft.com,
devel@linuxdriverproject.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] hv_netvsc: add ethtool support for set and get of settings
Date: Mon, 29 Feb 2016 17:50:40 -0500 (EST) [thread overview]
Message-ID: <20160229.175040.1966545191136367460.davem@davemloft.net> (raw)
In-Reply-To: <1456785278.3098.146.camel@decadent.org.uk>
From: Ben Hutchings <ben@decadent.org.uk>
Date: Mon, 29 Feb 2016 22:34:38 +0000
> On Mon, 2016-02-29 at 17:09 -0500, David Miller wrote:
>> From: Simon Xiao <sixiao@microsoft.com>
>> Date: Thu, 25 Feb 2016 15:24:08 -0800
>>
>> > This patch allows the user to set and retrieve speed and duplex of the
>> > hv_netvsc device via ethtool.
>> >
>> > Example:
>> > $ ethtool eth0
>> > Settings for eth0:
>> > ...
>> > Speed: Unknown!
>> > Duplex: Unknown! (255)
>> > ...
>> > $ ethtool -s eth0 speed 1000 duplex full
>> > $ ethtool eth0
>> > Settings for eth0:
>> > ...
>> > Speed: 1000Mb/s
>> > Duplex: Full
>> > ...
>> >
>> > This is based on patches by Roopa Prabhu and Nikolay Aleksandrov.
>> >
>> > Signed-off-by: Simon Xiao <sixiao@microsoft.com>
>>
>> Applied, thanks.
>
> I missed this due to flu, but now I look at it - I don't see the point.
> Link speed isn't meaingful for a memory-based transport, so "unknown"
> is correct. The link is effectively full duplex though.
>
> If the issue is that ethtool is a bit shouty about unknowns, let's
> consider changing that in ethtool, not teaching drivers to lie.
The issue is that certain bonding modes do not work properly without
a speed being reported by a device.
We're doing this for other "virtual" devices already thanks to changes
that went in last week, so there is precedence.
next prev parent reply other threads:[~2016-02-29 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 23:24 [PATCH net-next] hv_netvsc: add ethtool support for set and get of settings Simon Xiao
2016-02-29 22:09 ` David Miller
2016-02-29 22:34 ` Ben Hutchings
2016-02-29 22:50 ` David Miller [this message]
2016-03-01 15:31 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160229.175040.1966545191136367460.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sixiao@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).