From: David Miller <davem@davemloft.net>
To: peterz@infradead.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
rjw@rjwysocki.net, konrad.wilk@oracle.com, mingo@kernel.org,
paulmck@linux.vnet.ibm.com, tj@kernel.org,
linux-acpi@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC][PATCH] tags: Fix DEFINE_PER_CPU expansions
Date: Tue, 01 Mar 2016 11:36:42 -0500 (EST) [thread overview]
Message-ID: <20160301.113642.1119377555960644780.davem@davemloft.net> (raw)
In-Reply-To: <20160301102625.GQ6357@twins.programming.kicks-ass.net>
From: Peter Zijlstra <peterz@infradead.org>
Date: Tue, 1 Mar 2016 11:26:25 +0100
>
> $ make tags
> GEN tags
> ctags: Warning: drivers/acpi/processor_idle.c:64: null expansion of name pattern "\1"
> ctags: Warning: drivers/xen/events/events_2l.c:41: null expansion of name pattern "\1"
> ctags: Warning: kernel/locking/lockdep.c:151: null expansion of name pattern "\1"
> ctags: Warning: kernel/rcu/rcutorture.c:133: null expansion of name pattern "\1"
> ctags: Warning: kernel/rcu/rcutorture.c:135: null expansion of name pattern "\1"
> ctags: Warning: kernel/workqueue.c:323: null expansion of name pattern "\1"
> ctags: Warning: net/ipv4/syncookies.c:53: null expansion of name pattern "\1"
> ctags: Warning: net/ipv6/syncookies.c:44: null expansion of name pattern "\1"
> ctags: Warning: net/rds/page.c:45: null expansion of name pattern "\1"
>
> Which are all the result of the DEFINE_PER_CPU pattern:
>
> scripts/tags.sh:200: '/\<DEFINE_PER_CPU([^,]*, *\([[:alnum:]_]*\)/\1/v/'
> scripts/tags.sh:201: '/\<DEFINE_PER_CPU_SHARED_ALIGNED([^,]*, *\([[:alnum:]_]*\)/\1/v/'
>
> The below cures them. All except the workqueue one are within reasonable
> distance of the 80 char limit. TJ do you have any preference on how to
> fix the wq one, or shall we just not care its too long?
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
For the networking bits:
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2016-03-01 16:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 10:26 [RFC][PATCH] tags: Fix DEFINE_PER_CPU expansions Peter Zijlstra
2016-03-01 16:36 ` David Miller [this message]
2016-03-01 16:37 ` Tejun Heo
2016-03-01 18:18 ` Peter Zijlstra
2016-03-01 18:49 ` Tejun Heo
2016-03-01 16:56 ` Paul E. McKenney
2016-03-01 21:34 ` Peter Zijlstra
2016-03-01 22:01 ` Paul E. McKenney
2016-03-01 21:39 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301.113642.1119377555960644780.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).