From: David Miller <davem@davemloft.net>
To: ben@decadent.org.uk
Cc: nicolas.dichtel@6wind.com, netdev@vger.kernel.org,
nikolay@cumulusnetworks.com, kan.liang@intel.com
Subject: Re: [PATCH net-next] ethtool.h: define DIV_ROUND_UP for userland
Date: Tue, 01 Mar 2016 14:48:26 -0500 (EST) [thread overview]
Message-ID: <20160301.144826.104748964516491333.davem@davemloft.net> (raw)
In-Reply-To: <1456852446.3098.157.camel@decadent.org.uk>
From: Ben Hutchings <ben@decadent.org.uk>
Date: Tue, 01 Mar 2016 17:14:06 +0000
> On Tue, 2016-03-01 at 11:42 -0500, David Miller wrote:
>> From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>> Date: Tue, 1 Mar 2016 16:20:41 +0100
>>
>> > DIV_ROUND_UP and is defined in linux/kernel.h only for the kernel. INT_MAX
>> > needs limits.h in userland.
>>
>> It is wrong to provide a definition of this in the user visible global
>> namespace.
>
> Which is why he's not doing that...
No, that's exactly what he's doing:
+#ifndef __KERNEL__
+#include <limits.h> /* for INT_MAX */
+#define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
+#endif
in a uapi header file.
"If not kernel, define DEV_ROUND_UP"
next prev parent reply other threads:[~2016-03-01 19:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 15:20 [PATCH net-next] ethtool.h: define DIV_ROUND_UP for userland Nicolas Dichtel
2016-03-01 15:29 ` Ben Hutchings
2016-03-01 16:41 ` [PATCH net-next v2 1/2] uapi: " Nicolas Dichtel
2016-03-01 16:41 ` [PATCH net-next v2 2/2] ethtool.h: define INT_MAX " Nicolas Dichtel
2016-03-03 21:43 ` David Miller
2016-03-03 21:43 ` [PATCH net-next v2 1/2] uapi: define DIV_ROUND_UP " David Miller
2016-03-03 22:08 ` David Miller
2016-03-04 10:52 ` [PATCH net-next v3 0/4] uapi: consolidate DIV_ROUND_UP definition Nicolas Dichtel
2016-03-04 10:52 ` [PATCH net-next v3 1/4] uapi: define DIV_ROUND_UP for userland Nicolas Dichtel
2016-03-04 10:52 ` [PATCH net-next v3 2/4] cxgb4i: don't redefine DIV_ROUND_UP Nicolas Dichtel
2016-03-04 10:52 ` [PATCH net-next v3 3/4] drm/vmwgfx: remove userland definition of DIV_ROUND_UP Nicolas Dichtel
2016-03-04 21:36 ` Emil Velikov
2016-03-04 10:52 ` [PATCH net-next v3 4/4] ethtool.h: define INT_MAX for userland Nicolas Dichtel
2016-03-04 13:10 ` Nikolay Aleksandrov
2016-03-04 21:10 ` [PATCH net-next v3 0/4] uapi: consolidate DIV_ROUND_UP definition David Miller
2016-03-01 16:42 ` [PATCH net-next] ethtool.h: define DIV_ROUND_UP for userland David Miller
2016-03-01 17:14 ` Ben Hutchings
2016-03-01 19:48 ` David Miller [this message]
2016-03-01 20:06 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301.144826.104748964516491333.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=kan.liang@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).